* [PATCH] hexagon: drop empty and unused free_initrd_mem
@ 2019-08-15 8:35 Mike Rapoport
2019-08-15 13:27 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Mike Rapoport @ 2019-08-15 8:35 UTC (permalink / raw)
To: Richard Kuo
Cc: Andrew Morton, Christoph Hellwig, linux-hexagon, linux-kernel,
Mike Rapoport
hexagon never reserves or initializes initrd and the only mention of it is
the empty free_initrd_mem() function.
As we have a generic implementation of free_initrd_mem(), there is no need
to define an empty stub for the hexagon implementation and it can be
dropped.
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/hexagon/mm/init.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/arch/hexagon/mm/init.c b/arch/hexagon/mm/init.c
index f1f6ebd..c961773 100644
--- a/arch/hexagon/mm/init.c
+++ b/arch/hexagon/mm/init.c
@@ -71,19 +71,6 @@ void __init mem_init(void)
init_mm.context.ptbase = __pa(init_mm.pgd);
}
-/*
- * free_initrd_mem - frees... initrd memory.
- * @start - start of init memory
- * @end - end of init memory
- *
- * Apparently has to be passed the address of the initrd memory.
- *
- * Wrapped by #ifdef CONFIG_BLKDEV_INITRD
- */
-void free_initrd_mem(unsigned long start, unsigned long end)
-{
-}
-
void sync_icache_dcache(pte_t pte)
{
unsigned long addr;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hexagon: drop empty and unused free_initrd_mem
2019-08-15 8:35 [PATCH] hexagon: drop empty and unused free_initrd_mem Mike Rapoport
@ 2019-08-15 13:27 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-08-15 13:27 UTC (permalink / raw)
To: Mike Rapoport
Cc: Richard Kuo, Andrew Morton, Christoph Hellwig, linux-hexagon,
linux-kernel
On Thu, Aug 15, 2019 at 11:35:33AM +0300, Mike Rapoport wrote:
> hexagon never reserves or initializes initrd and the only mention of it is
> the empty free_initrd_mem() function.
>
> As we have a generic implementation of free_initrd_mem(), there is no need
> to define an empty stub for the hexagon implementation and it can be
> dropped.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-15 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 8:35 [PATCH] hexagon: drop empty and unused free_initrd_mem Mike Rapoport
2019-08-15 13:27 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).