* [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()
@ 2020-05-25 13:08 Tiezhu Yang
2020-05-25 13:08 ` [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile Tiezhu Yang
2020-06-24 13:01 ` [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Tiezhu Yang @ 2020-05-25 13:08 UTC (permalink / raw)
To: Heiko Stuebner, Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger
Cc: linux-rockchip, linux-kernel, Xuefeng Li, Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.
Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
v2:
- No changes, just add Reviewed-by tag
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index a7c6c94..8af8c6c 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -607,8 +607,8 @@ static int inno_dsidphy_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, inno);
inno->phy_base = devm_platform_ioremap_resource(pdev, 0);
- if (!inno->phy_base)
- return -ENOMEM;
+ if (IS_ERR(inno->phy_base))
+ return PTR_ERR(inno->phy_base);
inno->ref_clk = devm_clk_get(dev, "ref");
if (IS_ERR(inno->ref_clk)) {
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile
2020-05-25 13:08 [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Tiezhu Yang
@ 2020-05-25 13:08 ` Tiezhu Yang
2020-05-25 15:01 ` Heiko Stübner
2020-06-24 13:01 ` [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Vinod Koul
1 sibling, 1 reply; 4+ messages in thread
From: Tiezhu Yang @ 2020-05-25 13:08 UTC (permalink / raw)
To: Heiko Stuebner, Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger
Cc: linux-rockchip, linux-kernel, Xuefeng Li, Tiezhu Yang
If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in
the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check
in drivers/phy/Makefile.
Since the related configs in drivers/phy/rockchip/Kconfig depend on
ARCH_ROCKCHIP, so remove CONFIG_ARCH_ROCKCHIP check for subdir rockchip
in drivers/phy/Makefile.
The other CONFIG_ARCH_* about allwinner, amlogic, mediatek, renesas and
tegra have the same situation, so remove them too.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
v2:
- Remove all the CONFIG_ARCH_* check for related subdir in Makefile
- Modify the patch subject and update commit message
drivers/phy/Makefile | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index 310c149..16e2622 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -8,24 +8,24 @@ obj-$(CONFIG_GENERIC_PHY_MIPI_DPHY) += phy-core-mipi-dphy.o
obj-$(CONFIG_PHY_LPC18XX_USB_OTG) += phy-lpc18xx-usb-otg.o
obj-$(CONFIG_PHY_XGENE) += phy-xgene.o
obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o
-obj-$(CONFIG_ARCH_SUNXI) += allwinner/
-obj-$(CONFIG_ARCH_MESON) += amlogic/
-obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/
-obj-$(CONFIG_ARCH_RENESAS) += renesas/
-obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
-obj-$(CONFIG_ARCH_TEGRA) += tegra/
-obj-y += broadcom/ \
+obj-y += allwinner/ \
+ amlogic/ \
+ broadcom/ \
cadence/ \
freescale/ \
hisilicon/ \
intel/ \
lantiq/ \
marvell/ \
+ mediatek/ \
motorola/ \
mscc/ \
qualcomm/ \
ralink/ \
+ renesas/ \
+ rockchip/ \
samsung/ \
socionext/ \
st/ \
+ tegra/ \
ti/
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile
2020-05-25 13:08 ` [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile Tiezhu Yang
@ 2020-05-25 15:01 ` Heiko Stübner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2020-05-25 15:01 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger,
linux-rockchip, linux-kernel, Xuefeng Li
Am Montag, 25. Mai 2020, 15:08:58 CEST schrieb Tiezhu Yang:
> If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in
> the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check
> in drivers/phy/Makefile.
>
> Since the related configs in drivers/phy/rockchip/Kconfig depend on
> ARCH_ROCKCHIP, so remove CONFIG_ARCH_ROCKCHIP check for subdir rockchip
> in drivers/phy/Makefile.
>
> The other CONFIG_ARCH_* about allwinner, amlogic, mediatek, renesas and
> tegra have the same situation, so remove them too.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
I did check the other vendor directories and all options there do
seem to depend on some ARCH_foo || COMPILE_TEST variant, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
> ---
>
> v2:
> - Remove all the CONFIG_ARCH_* check for related subdir in Makefile
> - Modify the patch subject and update commit message
>
> drivers/phy/Makefile | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index 310c149..16e2622 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -8,24 +8,24 @@ obj-$(CONFIG_GENERIC_PHY_MIPI_DPHY) += phy-core-mipi-dphy.o
> obj-$(CONFIG_PHY_LPC18XX_USB_OTG) += phy-lpc18xx-usb-otg.o
> obj-$(CONFIG_PHY_XGENE) += phy-xgene.o
> obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o
> -obj-$(CONFIG_ARCH_SUNXI) += allwinner/
> -obj-$(CONFIG_ARCH_MESON) += amlogic/
> -obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/
> -obj-$(CONFIG_ARCH_RENESAS) += renesas/
> -obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
> -obj-$(CONFIG_ARCH_TEGRA) += tegra/
> -obj-y += broadcom/ \
> +obj-y += allwinner/ \
> + amlogic/ \
> + broadcom/ \
> cadence/ \
> freescale/ \
> hisilicon/ \
> intel/ \
> lantiq/ \
> marvell/ \
> + mediatek/ \
> motorola/ \
> mscc/ \
> qualcomm/ \
> ralink/ \
> + renesas/ \
> + rockchip/ \
> samsung/ \
> socionext/ \
> st/ \
> + tegra/ \
> ti/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()
2020-05-25 13:08 [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Tiezhu Yang
2020-05-25 13:08 ` [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile Tiezhu Yang
@ 2020-06-24 13:01 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-06-24 13:01 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Heiko Stuebner, Kishon Vijay Abraham I, Matthias Brugger,
linux-rockchip, linux-kernel, Xuefeng Li
On 25-05-20, 21:08, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
Applied both, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-24 13:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 13:08 [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Tiezhu Yang
2020-05-25 13:08 ` [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile Tiezhu Yang
2020-05-25 15:01 ` Heiko Stübner
2020-06-24 13:01 ` [PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).