* [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level
@ 2020-05-27 2:57 Zijun Hu
2020-05-27 16:23 ` Matthias Kaehlcke
2020-05-28 8:16 ` Marcel Holtmann
0 siblings, 2 replies; 4+ messages in thread
From: Zijun Hu @ 2020-05-27 2:57 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar, c-hbandi,
hemantg, mka, rjliao, zijuhu
Controller ID info got by VSC EDL_PATCH_GETVER is very
important, so improve its log level from DEBUG to INFO.
Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
---
drivers/bluetooth/btqca.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 3ea866d..94d8e15 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
ver = (struct qca_btsoc_version *)(edl->data);
- BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
- BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
- BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
- BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
+ bt_dev_info(hdev, "QCA Product ID :0x%08x",
+ le32_to_cpu(ver->product_id));
+ bt_dev_info(hdev, "QCA SOC Version :0x%08x",
+ le32_to_cpu(ver->soc_id));
+ bt_dev_info(hdev, "QCA ROM Version :0x%08x",
+ le16_to_cpu(ver->rom_ver));
+ bt_dev_info(hdev, "QCA Patch Version:0x%08x",
+ le16_to_cpu(ver->patch_ver));
/* QCA chipset version can be decided by patch and SoC
* version, combination with upper 2 bytes from SoC
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level
2020-05-27 2:57 [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level Zijun Hu
@ 2020-05-27 16:23 ` Matthias Kaehlcke
2020-05-28 8:16 ` Marcel Holtmann
1 sibling, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2020-05-27 16:23 UTC (permalink / raw)
To: Zijun Hu
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth,
linux-arm-msm, bgodavar, c-hbandi, hemantg, rjliao
On Wed, May 27, 2020 at 10:57:09AM +0800, Zijun Hu wrote:
> Controller ID info got by VSC EDL_PATCH_GETVER is very
> important, so improve its log level from DEBUG to INFO.
>
> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
> ---
> drivers/bluetooth/btqca.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 3ea866d..94d8e15 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
>
> ver = (struct qca_btsoc_version *)(edl->data);
>
> - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
> - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
> - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
> - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
> + bt_dev_info(hdev, "QCA Product ID :0x%08x",
> + le32_to_cpu(ver->product_id));
> + bt_dev_info(hdev, "QCA SOC Version :0x%08x",
> + le32_to_cpu(ver->soc_id));
> + bt_dev_info(hdev, "QCA ROM Version :0x%08x",
> + le16_to_cpu(ver->rom_ver));
> + bt_dev_info(hdev, "QCA Patch Version:0x%08x",
> + le16_to_cpu(ver->patch_ver));
>
> /* QCA chipset version can be decided by patch and SoC
> * version, combination with upper 2 bytes from SoC
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level
2020-05-27 2:57 [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level Zijun Hu
2020-05-27 16:23 ` Matthias Kaehlcke
@ 2020-05-28 8:16 ` Marcel Holtmann
2020-05-28 9:31 ` Zijun Hu
1 sibling, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2020-05-28 8:16 UTC (permalink / raw)
To: Zijun Hu
Cc: Johan Hedberg, LKML, linux-bluetooth, linux-arm-msm, bgodavar,
c-hbandi, hemantg, mka, rjliao
Hi Zijun,
> Controller ID info got by VSC EDL_PATCH_GETVER is very
> important, so improve its log level from DEBUG to INFO.
>
> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
> ---
> drivers/bluetooth/btqca.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 3ea866d..94d8e15 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
>
> ver = (struct qca_btsoc_version *)(edl->data);
>
> - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
> - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
> - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
> - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
> + bt_dev_info(hdev, "QCA Product ID :0x%08x",
> + le32_to_cpu(ver->product_id));
> + bt_dev_info(hdev, "QCA SOC Version :0x%08x",
> + le32_to_cpu(ver->soc_id));
> + bt_dev_info(hdev, "QCA ROM Version :0x%08x",
> + le16_to_cpu(ver->rom_ver));
> + bt_dev_info(hdev, "QCA Patch Version:0x%08x",
> + le16_to_cpu(ver->patch_ver));
please align correctly according to the coding style.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level
2020-05-28 8:16 ` Marcel Holtmann
@ 2020-05-28 9:31 ` Zijun Hu
0 siblings, 0 replies; 4+ messages in thread
From: Zijun Hu @ 2020-05-28 9:31 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Johan Hedberg, LKML, linux-bluetooth, linux-arm-msm, bgodavar,
c-hbandi, hemantg, mka, rjliao
On 5/28/2020 4:16 PM, Marcel Holtmann wrote:
> Hi Zijun,
>
>> Controller ID info got by VSC EDL_PATCH_GETVER is very
>> important, so improve its log level from DEBUG to INFO.
>>
>> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
>> ---
>> drivers/bluetooth/btqca.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index 3ea866d..94d8e15 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
>>
>> ver = (struct qca_btsoc_version *)(edl->data);
>>
>> - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
>> - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
>> - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
>> - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
>> + bt_dev_info(hdev, "QCA Product ID :0x%08x",
>> + le32_to_cpu(ver->product_id));
>> + bt_dev_info(hdev, "QCA SOC Version :0x%08x",
>> + le32_to_cpu(ver->soc_id));
>> + bt_dev_info(hdev, "QCA ROM Version :0x%08x",
>> + le16_to_cpu(ver->rom_ver));
>> + bt_dev_info(hdev, "QCA Patch Version:0x%08x",
>> + le16_to_cpu(ver->patch_ver));
>
> please align correctly according to the coding style.
>
if bt_dev_info() is wrote at one line, it will exceed 80 characters
so i split it at two line and aligned via vim.
> Regards
>
> Marcel
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-28 9:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 2:57 [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level Zijun Hu
2020-05-27 16:23 ` Matthias Kaehlcke
2020-05-28 8:16 ` Marcel Holtmann
2020-05-28 9:31 ` Zijun Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).