* [v2,1/1] hwmon:(nct7904) Set default timeout
@ 2020-05-27 3:49 yuechao.zhao
2020-05-27 5:02 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: yuechao.zhao @ 2020-05-27 3:49 UTC (permalink / raw)
To: 345351830
Cc: amy.shih, oakley.ding, jia.sui, Yuechao Zhao, Jean Delvare,
Guenter Roeck, linux-hwmon, linux-kernel
From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
The timeout module parameter should not be used for setting the default
timeout. Because, if you set the timeout = 0, the default timeout will
be meaningless. And the timeout module parameter of 0 means "no timeout
module paraameter specified".
Signed-off-by: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
---
- modify subject to 'hwmon:(nct7904) Set default timeout'
---
drivers/hwmon/nct7904.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 18c95be..27eb276 100644
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -1147,7 +1147,7 @@ static int nct7904_probe(struct i2c_client *client,
data->wdt.ops = &nct7904_wdt_ops;
data->wdt.info = &nct7904_wdt_info;
- data->wdt.timeout = timeout * 60; /* in seconds */
+ data->wdt.timeout = WATCHDOG_TIMEOUT * 60; /* Set default timeout */
data->wdt.min_timeout = MIN_TIMEOUT;
data->wdt.max_timeout = MAX_TIMEOUT;
data->wdt.parent = &client->dev;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2,1/1] hwmon:(nct7904) Set default timeout
2020-05-27 3:49 [v2,1/1] hwmon:(nct7904) Set default timeout yuechao.zhao
@ 2020-05-27 5:02 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-05-27 5:02 UTC (permalink / raw)
To: yuechao.zhao
Cc: 345351830, amy.shih, oakley.ding, jia.sui, Jean Delvare,
linux-hwmon, linux-kernel
On Wed, May 27, 2020 at 03:49:50AM +0000, yuechao.zhao@advantech.com.cn wrote:
> From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
>
> The timeout module parameter should not be used for setting the default
> timeout. Because, if you set the timeout = 0, the default timeout will
> be meaningless. And the timeout module parameter of 0 means "no timeout
> module paraameter specified".
>
> Signed-off-by: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
You should also replace
static int timeout = WATCHDOG_TIMEOUT;
with
static int timeout;
to ensure that the module parameter is only evaluated if it is actually
set. Otherwise your patch has no real impact except if someone explicitly
specifies a timeout parameter of 0 which doesn't really make much sense.
Thanks,
Guenter
> ---
> - modify subject to 'hwmon:(nct7904) Set default timeout'
> ---
> drivers/hwmon/nct7904.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 18c95be..27eb276 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -1147,7 +1147,7 @@ static int nct7904_probe(struct i2c_client *client,
> data->wdt.ops = &nct7904_wdt_ops;
> data->wdt.info = &nct7904_wdt_info;
>
> - data->wdt.timeout = timeout * 60; /* in seconds */
> + data->wdt.timeout = WATCHDOG_TIMEOUT * 60; /* Set default timeout */
> data->wdt.min_timeout = MIN_TIMEOUT;
> data->wdt.max_timeout = MAX_TIMEOUT;
> data->wdt.parent = &client->dev;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-27 5:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 3:49 [v2,1/1] hwmon:(nct7904) Set default timeout yuechao.zhao
2020-05-27 5:02 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).