[PATCH] clk: versatile: remove redundant assignment to pointer clk

* [PATCH] clk: versatile: remove redundant assignment to pointer clk
@ 2020-05-26 22:41 Colin King
  2020-05-27  5:49 ` Linus Walleij
  2020-05-27  6:40 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-05-26 22:41 UTC (permalink / raw)
  To: Linus Walleij, Michael Turquette, Stephen Boyd, linux-arm-kernel,
	linux-clk
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The pointer clk is being initialized with a value that is never read
and is being updated with a new value later on. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/clk/versatile/clk-versatile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c
index fd54d5c0251c..8ed7a179f651 100644
--- a/drivers/clk/versatile/clk-versatile.c
+++ b/drivers/clk/versatile/clk-versatile.c
@@ -56,7 +56,7 @@ static const struct clk_icst_desc versatile_auxosc_desc __initconst = {
 static void __init cm_osc_setup(struct device_node *np,
 				const struct clk_icst_desc *desc)
 {
-	struct clk *clk = ERR_PTR(-EINVAL);
+	struct clk *clk;
 	const char *clk_name = np->name;
 	const char *parent_name;
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread