* [PATCH] (one line): use #ifdef with CONFIG_*
@ 2003-04-22 8:27 Nikita Danilov
2003-04-22 8:35 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Nikita Danilov @ 2003-04-22 8:27 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Linus Torvalds, Andrew Morton
===== include/asm-i386/kmap_types.h 1.13 vs edited =====
--- 1.13/include/asm-i386/kmap_types.h Mon Feb 3 10:34:59 2003
+++ edited/include/asm-i386/kmap_types.h Tue Apr 22 11:58:17 2003
@@ -3,7 +3,7 @@
#include <linux/config.h>
-#if CONFIG_DEBUG_HIGHMEM
+#ifdef CONFIG_DEBUG_HIGHMEM
# define D(n) __KM_FENCE_##n ,
#else
# define D(n)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (one line): use #ifdef with CONFIG_*
2003-04-22 8:27 [PATCH] (one line): use #ifdef with CONFIG_* Nikita Danilov
@ 2003-04-22 8:35 ` Andrew Morton
2003-04-22 8:44 ` Nikita Danilov
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2003-04-22 8:35 UTC (permalink / raw)
To: Nikita Danilov; +Cc: Linux-Kernel, Torvalds
Nikita Danilov <Nikita@Namesys.COM> wrote:
>
> -#if CONFIG_DEBUG_HIGHMEM
> +#ifdef CONFIG_DEBUG_HIGHMEM
mnm:/usr/src/linux-2.5.68> grep -r '#if[ ]*CONFIG' . | wc -l
185
Why fix this one in particular?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (one line): use #ifdef with CONFIG_*
2003-04-22 8:35 ` Andrew Morton
@ 2003-04-22 8:44 ` Nikita Danilov
2003-04-22 13:59 ` Valdis.Kletnieks
0 siblings, 1 reply; 4+ messages in thread
From: Nikita Danilov @ 2003-04-22 8:44 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux-Kernel, Torvalds
Andrew Morton writes:
> Nikita Danilov <Nikita@Namesys.COM> wrote:
> >
> > -#if CONFIG_DEBUG_HIGHMEM
> > +#ifdef CONFIG_DEBUG_HIGHMEM
>
> mnm:/usr/src/linux-2.5.68> grep -r '#if[ ]*CONFIG' . | wc -l
> 185
>
> Why fix this one in particular?
Err, I just added -Wundef to cc options and it was the only one that has
shown up. Probably all of them should be corrected at once.
Nikita.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (one line): use #ifdef with CONFIG_*
2003-04-22 8:44 ` Nikita Danilov
@ 2003-04-22 13:59 ` Valdis.Kletnieks
0 siblings, 0 replies; 4+ messages in thread
From: Valdis.Kletnieks @ 2003-04-22 13:59 UTC (permalink / raw)
To: Nikita Danilov; +Cc: Andrew Morton, Linux-Kernel, Torvalds
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
On Tue, 22 Apr 2003 12:44:37 +0400, Nikita Danilov said:
> Err, I just added -Wundef to cc options and it was the only one that has
> shown up. Probably all of them should be corrected at once.
I submitted patches to clean a lot of this up, but not all seem to have
made it into Linus's kernel. I'll re-diff against 2.5.68 and re-send.
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-04-22 13:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-22 8:27 [PATCH] (one line): use #ifdef with CONFIG_* Nikita Danilov
2003-04-22 8:35 ` Andrew Morton
2003-04-22 8:44 ` Nikita Danilov
2003-04-22 13:59 ` Valdis.Kletnieks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).