From: Yunsheng Lin <linyunsheng@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <will@kernel.org>,
<viro@zeniv.linux.org.uk>, <kyk.segfault@gmail.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <linmiaohe@huawei.com>,
<martin.varghese@nokia.com>, <pabeni@redhat.com>,
<pshelar@ovn.org>, <fw@strlen.de>, <gnault@redhat.com>,
<steffen.klassert@secunet.com>, <vladimir.oltean@nxp.com>,
<edumazet@google.com>, <saeed@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: [PATCH net-next v2 2/2] net: Use lockdep_assert_in_softirq() in napi_consume_skb()
Date: Sat, 21 Nov 2020 11:06:16 +0800 [thread overview]
Message-ID: <1605927976-232804-3-git-send-email-linyunsheng@huawei.com> (raw)
In-Reply-To: <1605927976-232804-1-git-send-email-linyunsheng@huawei.com>
Use napi_consume_skb() to assert the case when it is not called
in a atomic softirq context.
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
net/core/skbuff.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ffe3dcc..effa19d 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -902,6 +902,8 @@ void napi_consume_skb(struct sk_buff *skb, int budget)
return;
}
+ lockdep_assert_in_softirq();
+
if (!skb_unref(skb))
return;
--
2.8.1
prev parent reply other threads:[~2020-11-21 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 3:06 [PATCH net-next v2 0/2] Add an assert in napi_consume_skb() Yunsheng Lin
2020-11-21 3:06 ` [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert Yunsheng Lin
2020-11-23 14:27 ` Peter Zijlstra
2020-11-23 20:12 ` Jakub Kicinski
2020-11-24 8:11 ` Peter Zijlstra
2020-11-24 10:30 ` Yunsheng Lin
2020-11-21 3:06 ` Yunsheng Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605927976-232804-3-git-send-email-linyunsheng@huawei.com \
--to=linyunsheng@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=kyk.segfault@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.varghese@nokia.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=pshelar@ovn.org \
--cc=saeed@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).