From: Jakub Kicinski <kuba@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
Yunsheng Lin <linyunsheng@huawei.com>
Cc: mingo@redhat.com, will@kernel.org, viro@zeniv.linux.org.uk,
kyk.segfault@gmail.com, davem@davemloft.net,
linmiaohe@huawei.com, martin.varghese@nokia.com,
pabeni@redhat.com, pshelar@ovn.org, fw@strlen.de,
gnault@redhat.com, steffen.klassert@secunet.com,
vladimir.oltean@nxp.com, edumazet@google.com, saeed@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert
Date: Mon, 23 Nov 2020 12:12:59 -0800 [thread overview]
Message-ID: <20201123121259.312dcb82@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201123142725.GQ3021@hirez.programming.kicks-ass.net>
On Mon, 23 Nov 2020 15:27:25 +0100 Peter Zijlstra wrote:
> On Sat, Nov 21, 2020 at 11:06:15AM +0800, Yunsheng Lin wrote:
> > The current semantic for napi_consume_skb() is that caller need
> > to provide non-zero budget when calling from NAPI context, and
> > breaking this semantic will cause hard to debug problem, because
> > _kfree_skb_defer() need to run in atomic context in order to push
> > the skb to the particular cpu' napi_alloc_cache atomically.
> >
> > So add the lockdep_assert_in_softirq() to assert when the running
> > context is not in_softirq, in_softirq means softirq is serving or
> > BH is disabled. Because the softirq context can be interrupted by
> > hard IRQ or NMI context, so lockdep_assert_in_softirq() need to
> > assert about hard IRQ or NMI context too.
> Due to in_softirq() having a deprication notice (due to it being
> awefully ambiguous), could we have a nice big comment here that explains
> in detail understandable to !network people (me) why this is actually
> correct?
>
> I'm not opposed to the thing, if that his what you need, it's fine, but
> please put on a comment that explains that in_softirq() is ambiguous and
> when you really do need it anyway.
One liner would be:
* Acceptable for protecting per-CPU resources accessed from BH
We can add:
* Much like in_softirq() - semantics are ambiguous, use carefully. *
IIUC we basically want to protect the nc array and counter here:
static inline void _kfree_skb_defer(struct sk_buff *skb)
{
struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
/* drop skb->head and call any destructors for packet */
skb_release_all(skb);
/* record skb to CPU local list */
nc->skb_cache[nc->skb_count++] = skb;
#ifdef CONFIG_SLUB
/* SLUB writes into objects when freeing */
prefetchw(skb);
#endif
/* flush skb_cache if it is filled */
if (unlikely(nc->skb_count == NAPI_SKB_CACHE_SIZE)) {
kmem_cache_free_bulk(skbuff_head_cache, NAPI_SKB_CACHE_SIZE,
nc->skb_cache);
nc->skb_count = 0;
}
}
> > +#define lockdep_assert_in_softirq() \
> > +do { \
> > + WARN_ON_ONCE(__lockdep_enabled && \
> > + (!in_softirq() || in_irq() || in_nmi())); \
> > +} while (0)
next prev parent reply other threads:[~2020-11-23 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 3:06 [PATCH net-next v2 0/2] Add an assert in napi_consume_skb() Yunsheng Lin
2020-11-21 3:06 ` [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert Yunsheng Lin
2020-11-23 14:27 ` Peter Zijlstra
2020-11-23 20:12 ` Jakub Kicinski [this message]
2020-11-24 8:11 ` Peter Zijlstra
2020-11-24 10:30 ` Yunsheng Lin
2020-11-21 3:06 ` [PATCH net-next v2 2/2] net: Use lockdep_assert_in_softirq() in napi_consume_skb() Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123121259.312dcb82@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=kyk.segfault@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=martin.varghese@nokia.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=pshelar@ovn.org \
--cc=saeed@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).