From: Xu Yilun <yilun.xu@intel.com>
To: lee.jones@linaro.org, linux-kernel@vger.kernel.org
Cc: trix@redhat.com, yilun.xu@intel.com,
matthew.gerlach@linux.intel.com, russell.h.weight@intel.com,
lgoncalv@redhat.com, hao.wu@intel.com
Subject: [PATCH v2 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition
Date: Tue, 26 Jan 2021 14:50:34 +0800 [thread overview]
Message-ID: <1611643836-7183-3-git-send-email-yilun.xu@intel.com> (raw)
In-Reply-To: <1611643836-7183-1-git-send-email-yilun.xu@intel.com>
The version register is the only one in the legacy I/O space to be
accessed, so it is not necessary to define the legacy base & version
register offset. A direct definition of the legacy version register
address would be fine.
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
---
drivers/mfd/intel-m10-bmc.c | 12 +++++-------
include/linux/mfd/intel-m10-bmc.h | 2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c
index b84579b..aad86f0 100644
--- a/drivers/mfd/intel-m10-bmc.c
+++ b/drivers/mfd/intel-m10-bmc.c
@@ -74,16 +74,14 @@ static int check_m10bmc_version(struct intel_m10bmc *ddata)
/*
* This check is to filter out the very old legacy BMC versions,
- * M10BMC_LEGACY_SYS_BASE is the offset to this old block of mmio
- * registers. In the old BMC chips, the BMC version info is stored
- * in this old version register (M10BMC_LEGACY_SYS_BASE +
- * M10BMC_BUILD_VER), so its read out value would have not been
- * LEGACY_INVALID (0xffffffff). But in new BMC chips that the
+ * 0x300400 is the offset to this old block of mmio registers. In the
+ * old BMC chips, the BMC version info is stored in this old version
+ * register (0x300400 + 0x68), so its read out value would have not
+ * been LEGACY_INVALID (0xffffffff). But in new BMC chips that the
* driver supports, the value of this register should be
* LEGACY_INVALID.
*/
- ret = m10bmc_raw_read(ddata,
- M10BMC_LEGACY_SYS_BASE + M10BMC_BUILD_VER, &v);
+ ret = m10bmc_raw_read(ddata, M10BMC_LEGACY_BUILD_VER, &v);
if (ret)
return -ENODEV;
diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
index 06da62c..99f44b1 100644
--- a/include/linux/mfd/intel-m10-bmc.h
+++ b/include/linux/mfd/intel-m10-bmc.h
@@ -9,7 +9,7 @@
#include <linux/regmap.h>
-#define M10BMC_LEGACY_SYS_BASE 0x300400
+#define M10BMC_LEGACY_BUILD_VER 0x300468
#define M10BMC_SYS_BASE 0x300800
#define M10BMC_MEM_END 0x1fffffff
--
2.7.4
next prev parent reply other threads:[~2021-01-26 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 6:50 [PATCH v2 0/4] Some improvement for Intel MAX 10 MFD drivers Xu Yilun
2021-01-26 6:50 ` [PATCH v2 1/4] mfd: intel-m10-bmc: Fix the register access range Xu Yilun
2021-01-26 6:50 ` Xu Yilun [this message]
2021-01-26 14:58 ` [PATCH v2 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition Tom Rix
2021-01-26 6:50 ` [PATCH v2 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap Xu Yilun
2021-01-26 15:00 ` Tom Rix
2021-01-26 6:50 ` [PATCH v2 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver Xu Yilun
2021-01-26 15:06 ` Tom Rix
2021-01-27 1:33 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611643836-7183-3-git-send-email-yilun.xu@intel.com \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=lee.jones@linaro.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).