* [PATCH] mm/zswap: switch from strlcpy to strscpy
@ 2021-02-25 4:39 Zhiyuan Dai
0 siblings, 0 replies; only message in thread
From: Zhiyuan Dai @ 2021-02-25 4:39 UTC (permalink / raw)
To: sjenning, ddstreet, vitaly.wool, akpm; +Cc: linux-mm, linux-kernel, Zhiyuan Dai
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.
Signed-off-by: Zhiyuan Dai <daizhiyuan@phytium.com.cn>
---
mm/zswap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index 182f6ad..3a92d0b 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -614,7 +614,7 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor)
}
pr_debug("using %s zpool\n", zpool_get_type(pool->zpool));
- strlcpy(pool->tfm_name, compressor, sizeof(pool->tfm_name));
+ strscpy(pool->tfm_name, compressor, sizeof(pool->tfm_name));
pool->acomp_ctx = alloc_percpu(*pool->acomp_ctx);
if (!pool->acomp_ctx) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-25 4:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 4:39 [PATCH] mm/zswap: switch from strlcpy to strscpy Zhiyuan Dai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).