From: Stephen Boyd <swboyd@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>,
bjorn.andersson@linaro.org, p.zabel@pengutronix.de,
robh+dt@kernel.org
Cc: agross@kernel.org, mani@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH 5/6] reset: qcom: Add PDC Global reset signals for WPSS
Date: Sat, 13 Mar 2021 13:40:06 -0800 [thread overview]
Message-ID: <161567160672.1478170.9206499753037545854@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1615269111-25559-6-git-send-email-sibis@codeaurora.org>
Quoting Sibi Sankar (2021-03-08 21:51:50)
> Add PDC Global reset signals for Wireless Processor Subsystem (WPSS)
> on SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> drivers/reset/reset-qcom-pdc.c | 62 ++++++++++++++++++++++++++++++++++--------
> 1 file changed, 51 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c
> index ab74bccd4a5b..bb7113ae6232 100644
> --- a/drivers/reset/reset-qcom-pdc.c
> +++ b/drivers/reset/reset-qcom-pdc.c
> @@ -11,18 +11,26 @@
>
> #include <dt-bindings/reset/qcom,sdm845-pdc.h>
>
> -#define RPMH_PDC_SYNC_RESET 0x100
> +#define RPMH_SDM845_PDC_SYNC_RESET 0x100
> +#define RPMH_SC7280_PDC_SYNC_RESET 0x1000
>
> struct qcom_pdc_reset_map {
> u8 bit;
> };
>
> +struct qcom_pdc_reset_desc {
> + const struct qcom_pdc_reset_map *resets;
> + unsigned int offset;
> + size_t num_resets;
Please put num_resets next to resets and move offset before or after the
block. That way we know that resets and num_resets are related because
they're right next to each other.
> +};
> +
> struct qcom_pdc_reset_data {
> struct reset_controller_dev rcdev;
> struct regmap *regmap;
> + const struct qcom_pdc_reset_desc *desc;
> };
>
> -static const struct regmap_config sdm845_pdc_regmap_config = {
> +static const struct regmap_config pdc_regmap_config = {
> .name = "pdc-reset",
> .reg_bits = 32,
> .reg_stride = 4,
next prev parent reply other threads:[~2021-03-13 21:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 5:51 [PATCH 0/6] Enable miscellaneous hardware blocks to boot WPSS Sibi Sankar
2021-03-09 5:51 ` [PATCH 1/6] soc: qcom: smem: Update max processor count Sibi Sankar
2021-03-13 21:36 ` Stephen Boyd
2021-03-09 5:51 ` [PATCH 2/6] dt-bindings: mailbox: Add WPSS client index to IPCC Sibi Sankar
2021-03-13 21:37 ` Stephen Boyd
2021-03-16 22:07 ` Rob Herring
2021-03-09 5:51 ` [PATCH 3/6] dt-bindings: reset: aoss: Add AOSS reset controller binding Sibi Sankar
2021-03-13 21:37 ` Stephen Boyd
2021-03-16 22:07 ` Rob Herring
2021-03-09 5:51 ` [PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings Sibi Sankar
2021-03-13 21:37 ` Stephen Boyd
2021-04-19 10:27 ` Sibi Sankar
2021-03-16 22:08 ` Rob Herring
2021-03-09 5:51 ` [PATCH 5/6] reset: qcom: Add PDC Global reset signals for WPSS Sibi Sankar
2021-03-13 21:40 ` Stephen Boyd [this message]
2021-03-09 5:51 ` [PATCH 6/6] arm64: dts: qcom: sc7280: Add nodes to boot WPSS Sibi Sankar
2021-03-13 21:46 ` Stephen Boyd
2021-03-14 4:16 ` Bjorn Andersson
2021-03-23 22:06 ` Stephen Boyd
2021-03-24 6:49 ` Sibi Sankar
2021-04-19 10:10 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161567160672.1478170.9206499753037545854@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).