* [PATCH] drm/panel: lvds: Drop unnecessary NULL pointer checks for lvds->enable_gpio
@ 2021-04-20 7:47 Liu Ying
0 siblings, 0 replies; only message in thread
From: Liu Ying @ 2021-04-20 7:47 UTC (permalink / raw)
To: dri-devel
Cc: linux-kernel, linux-imx, Laurent Pinchart, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter
gpiod_set_value_cansleep() does NULL pointer check for passed in
gpio descriptor's pointer, so it's unnecessary to do that check
before calling that function. This patch drops those checks from
this panel driver.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
drivers/gpu/drm/panel/panel-lvds.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index 59a8d99..19f11fa 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -50,8 +50,7 @@ static int panel_lvds_unprepare(struct drm_panel *panel)
{
struct panel_lvds *lvds = to_panel_lvds(panel);
- if (lvds->enable_gpio)
- gpiod_set_value_cansleep(lvds->enable_gpio, 0);
+ gpiod_set_value_cansleep(lvds->enable_gpio, 0);
if (lvds->supply)
regulator_disable(lvds->supply);
@@ -74,8 +73,7 @@ static int panel_lvds_prepare(struct drm_panel *panel)
}
}
- if (lvds->enable_gpio)
- gpiod_set_value_cansleep(lvds->enable_gpio, 1);
+ gpiod_set_value_cansleep(lvds->enable_gpio, 1);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-20 8:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 7:47 [PATCH] drm/panel: lvds: Drop unnecessary NULL pointer checks for lvds->enable_gpio Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).