* [PATCH] lib/asn1_encoder: Remove redundant assignment to ret
@ 2021-05-06 10:18 Yang Li
0 siblings, 0 replies; only message in thread
From: Yang Li @ 2021-05-06 10:18 UTC (permalink / raw)
To: nathan; +Cc: ndesaulniers, linux-kernel, clang-built-linux, Yang Li
Variable 'ret' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Clean up the following clang-analyzer warning:
lib/asn1_encoder.c:167:2: warning: Value stored to 'ret' is never read
[clang-analyzer-deadcode.DeadStores]
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
lib/asn1_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/asn1_encoder.c b/lib/asn1_encoder.c
index 41e71aa..0d287ea 100644
--- a/lib/asn1_encoder.c
+++ b/lib/asn1_encoder.c
@@ -164,8 +164,6 @@ static int asn1_encode_oid_digit(unsigned char **_data, int *data_len, u32 oid)
data_len -= 3;
- ret = 0;
-
for (i = 2; i < oid_len; i++) {
ret = asn1_encode_oid_digit(&d, &data_len, oid[i]);
if (ret < 0)
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-06 10:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 10:18 [PATCH] lib/asn1_encoder: Remove redundant assignment to ret Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).