* [PATCH] powerpc/xive: Fix unsigned comparison with less than zero
@ 2021-05-07 10:20 Jiapeng Chong
2022-03-15 9:17 ` Christophe Leroy
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-07 10:20 UTC (permalink / raw)
To: mpe; +Cc: benh, paulus, linuxppc-dev, linux-kernel, Jiapeng Chong
The return from the call to irq_domain_alloc_irqs() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irq', this may lead to invalid if statement detection,
so that kfree execution is invalid. So making 'irq' an int.
Clean up the following coccicheck warning:
./arch/powerpc/sysdev/xive/common.c:1157:6-14: WARNING: Unsigned
expression compared with zero: xid -> irq < 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
arch/powerpc/sysdev/xive/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
index a830432..a5fd45a 100644
--- a/arch/powerpc/sysdev/xive/common.c
+++ b/arch/powerpc/sysdev/xive/common.c
@@ -65,7 +65,7 @@
#ifdef CONFIG_SMP
/* The IPIs use the same logical irq number when on the same chip */
static struct xive_ipi_desc {
- unsigned int irq;
+ int irq;
char name[16];
} *xive_ipis;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/xive: Fix unsigned comparison with less than zero
2021-05-07 10:20 [PATCH] powerpc/xive: Fix unsigned comparison with less than zero Jiapeng Chong
@ 2022-03-15 9:17 ` Christophe Leroy
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2022-03-15 9:17 UTC (permalink / raw)
To: Jiapeng Chong, mpe, Cédric Le Goater
Cc: paulus, linuxppc-dev, linux-kernel
Le 07/05/2021 à 12:20, Jiapeng Chong a écrit :
> The return from the call to irq_domain_alloc_irqs() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', this may lead to invalid if statement detection,
> so that kfree execution is invalid. So making 'irq' an int.
>
> Clean up the following coccicheck warning:
>
> ./arch/powerpc/sysdev/xive/common.c:1157:6-14: WARNING: Unsigned
> expression compared with zero: xid -> irq < 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
This was fixed by
https://github.com/linuxppc/linux/commit/3f601608b71c3ca1e199898cd16f09d707fedb56
> ---
> arch/powerpc/sysdev/xive/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
> index a830432..a5fd45a 100644
> --- a/arch/powerpc/sysdev/xive/common.c
> +++ b/arch/powerpc/sysdev/xive/common.c
> @@ -65,7 +65,7 @@
> #ifdef CONFIG_SMP
> /* The IPIs use the same logical irq number when on the same chip */
> static struct xive_ipi_desc {
> - unsigned int irq;
> + int irq;
> char name[16];
> } *xive_ipis;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 10:20 [PATCH] powerpc/xive: Fix unsigned comparison with less than zero Jiapeng Chong
2022-03-15 9:17 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).