* [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches
@ 2021-10-01 16:20 Andy Shevchenko
2021-10-01 19:11 ` Jakub Kicinski
2021-10-02 15:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-10-01 16:20 UTC (permalink / raw)
To: David S. Miller, Lee Jones, netdev, linux-kernel
Cc: Richard Cochran, Andy Shevchenko
The driver can't be loaded automatically because it misses
module alias to be provided. Add corresponding MODULE_DEVICE_TABLE()
call to the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/ptp/ptp_pch.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
index a17e8cc642c5..8070f3fd98f0 100644
--- a/drivers/ptp/ptp_pch.c
+++ b/drivers/ptp/ptp_pch.c
@@ -644,6 +644,7 @@ static const struct pci_device_id pch_ieee1588_pcidev_id[] = {
},
{0}
};
+MODULE_DEVICE_TABLE(pci, pch_ieee1588_pcidev_id);
static SIMPLE_DEV_PM_OPS(pch_pm_ops, pch_suspend, pch_resume);
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches
2021-10-01 16:20 [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches Andy Shevchenko
@ 2021-10-01 19:11 ` Jakub Kicinski
2021-10-01 19:32 ` Andy Shevchenko
2021-10-02 15:20 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2021-10-01 19:11 UTC (permalink / raw)
To: Andy Shevchenko
Cc: David S. Miller, Lee Jones, netdev, linux-kernel, Richard Cochran
On Fri, 1 Oct 2021 19:20:33 +0300 Andy Shevchenko wrote:
> The driver can't be loaded automatically because it misses
> module alias to be provided. Add corresponding MODULE_DEVICE_TABLE()
> call to the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Could you reply with a Fixes tag? (no need to resend, I think)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches
2021-10-01 19:11 ` Jakub Kicinski
@ 2021-10-01 19:32 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-10-01 19:32 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David S. Miller, Lee Jones, netdev, linux-kernel, Richard Cochran
On Fri, Oct 01, 2021 at 12:11:09PM -0700, Jakub Kicinski wrote:
> On Fri, 1 Oct 2021 19:20:33 +0300 Andy Shevchenko wrote:
> > The driver can't be loaded automatically because it misses
> > module alias to be provided. Add corresponding MODULE_DEVICE_TABLE()
> > call to the driver.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Could you reply with a Fixes tag? (no need to resend, I think)
Fixes: 863d08ece9bf ("supports eg20t ptp clock")
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches
2021-10-01 16:20 [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches Andy Shevchenko
2021-10-01 19:11 ` Jakub Kicinski
@ 2021-10-02 15:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-02 15:20 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: davem, lee.jones, netdev, linux-kernel, richardcochran
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 1 Oct 2021 19:20:33 +0300 you wrote:
> The driver can't be loaded automatically because it misses
> module alias to be provided. Add corresponding MODULE_DEVICE_TABLE()
> call to the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ptp/ptp_pch.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [v1,net,1/1] ptp_pch: Load module automatically if ID matches
https://git.kernel.org/netdev/net/c/7cd8b1542a7b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-02 15:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 16:20 [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches Andy Shevchenko
2021-10-01 19:11 ` Jakub Kicinski
2021-10-01 19:32 ` Andy Shevchenko
2021-10-02 15:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).