* [PATCH -next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()
@ 2021-11-30 3:38 Yang Yingliang
2021-11-30 12:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-11-30 3:38 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: olek2, davem, kuba
Add the missing free_netdev() before return from ltq_etop_probe()
in the error handling case.
Fixes: 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/lantiq_etop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 072391c494ce..14059e11710a 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -687,13 +687,13 @@ ltq_etop_probe(struct platform_device *pdev)
err = device_property_read_u32(&pdev->dev, "lantiq,tx-burst-length", &priv->tx_burst_len);
if (err < 0) {
dev_err(&pdev->dev, "unable to read tx-burst-length property\n");
- return err;
+ goto err_free;
}
err = device_property_read_u32(&pdev->dev, "lantiq,rx-burst-length", &priv->rx_burst_len);
if (err < 0) {
dev_err(&pdev->dev, "unable to read rx-burst-length property\n");
- return err;
+ goto err_free;
}
for (i = 0; i < MAX_DMA_CHAN; i++) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()
2021-11-30 3:38 [PATCH -next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe() Yang Yingliang
@ 2021-11-30 12:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-30 12:20 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, olek2, davem, kuba
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 30 Nov 2021 11:38:37 +0800 you wrote:
> Add the missing free_netdev() before return from ltq_etop_probe()
> in the error handling case.
>
> Fixes: 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/lantiq_etop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [-next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()
https://git.kernel.org/netdev/net-next/c/2680ce7fc993
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-30 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 3:38 [PATCH -next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe() Yang Yingliang
2021-11-30 12:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).