* [PATCH v4 0/2] MIPS: Remove some code
@ 2021-12-14 3:09 Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option Tiezhu Yang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tiezhu Yang @ 2021-12-14 3:09 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Jason Self, Masahiro Yamada, Ryutaroh Matsumoto,
Nathan Chancellor, linux-mips, linux-kernel
Thanks Nathan, Masahiro and Ryutaroh.
v4:
-- update the commit message of patch #1
-- add Reviewed-by tags
Tiezhu Yang (2):
MIPS: SGI-IP22: Remove unnecessary check of GCC option
MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
arch/mips/Makefile | 2 --
arch/mips/sgi-ip22/Platform | 5 -----
2 files changed, 7 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v4 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option
2021-12-14 3:09 [PATCH v4 0/2] MIPS: Remove some code Tiezhu Yang
@ 2021-12-14 3:09 ` Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms Tiezhu Yang
2021-12-14 9:32 ` [PATCH v4 0/2] MIPS: Remove some code Thomas Bogendoerfer
2 siblings, 0 replies; 4+ messages in thread
From: Tiezhu Yang @ 2021-12-14 3:09 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Jason Self, Masahiro Yamada, Ryutaroh Matsumoto,
Nathan Chancellor, linux-mips, linux-kernel
According to Documentation/process/changes.rst, the minimal version of GCC
is 5.1, and -mr10k-cache-barrier=store is supported with GCC 5.1 [1], just
remove the unnecessary check to fix the build error [2]:
arch/mips/sgi-ip22/Platform:28: *** gcc doesn't support needed option -mr10k-cache-barrier=store. Stop.
[1] https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/MIPS-Options.html
[2] https://github.com/ClangBuiltLinux/linux/issues/1543
Reported-by: Ryutaroh Matsumoto <ryutaroh@ict.e.titech.ac.jp>
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/mips/sgi-ip22/Platform | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/mips/sgi-ip22/Platform b/arch/mips/sgi-ip22/Platform
index 62fa30b..a4c46e3 100644
--- a/arch/mips/sgi-ip22/Platform
+++ b/arch/mips/sgi-ip22/Platform
@@ -23,10 +23,5 @@ endif
# be 16kb aligned or the handling of the current variable will break.
# Simplified: what IP22 does at 128MB+ in ksegN, IP28 does at 512MB+ in xkphys
#
-ifdef CONFIG_SGI_IP28
- ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
- $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
- endif
-endif
cflags-$(CONFIG_SGI_IP28) += -mr10k-cache-barrier=store -I$(srctree)/arch/mips/include/asm/mach-ip28
load-$(CONFIG_SGI_IP28) += 0xa800000020004000
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v4 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
2021-12-14 3:09 [PATCH v4 0/2] MIPS: Remove some code Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option Tiezhu Yang
@ 2021-12-14 3:09 ` Tiezhu Yang
2021-12-14 9:32 ` [PATCH v4 0/2] MIPS: Remove some code Thomas Bogendoerfer
2 siblings, 0 replies; 4+ messages in thread
From: Tiezhu Yang @ 2021-12-14 3:09 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Jason Self, Masahiro Yamada, Ryutaroh Matsumoto,
Nathan Chancellor, linux-mips, linux-kernel
After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
{as,cc}-option calls"), no need to use "ifdef need-compiler" for
Kbuild.platforms, because the cause of the build issue mentioned
in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
platform") has been disappeared, so just remove it.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/mips/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ace7f03..e036fc0 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -253,9 +253,7 @@ endif
#
# Board-dependent options and extra files
#
-ifdef need-compiler
include $(srctree)/arch/mips/Kbuild.platforms
-endif
ifdef CONFIG_PHYSICAL_START
load-y = $(CONFIG_PHYSICAL_START)
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4 0/2] MIPS: Remove some code
2021-12-14 3:09 [PATCH v4 0/2] MIPS: Remove some code Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms Tiezhu Yang
@ 2021-12-14 9:32 ` Thomas Bogendoerfer
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2021-12-14 9:32 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Jason Self, Masahiro Yamada, Ryutaroh Matsumoto,
Nathan Chancellor, linux-mips, linux-kernel
On Tue, Dec 14, 2021 at 11:09:00AM +0800, Tiezhu Yang wrote:
> Thanks Nathan, Masahiro and Ryutaroh.
>
> v4:
> -- update the commit message of patch #1
> -- add Reviewed-by tags
>
> Tiezhu Yang (2):
> MIPS: SGI-IP22: Remove unnecessary check of GCC option
> MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
>
> arch/mips/Makefile | 2 --
> arch/mips/sgi-ip22/Platform | 5 -----
> 2 files changed, 7 deletions(-)
>
> --
> 2.1.0
series applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-14 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 3:09 [PATCH v4 0/2] MIPS: Remove some code Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option Tiezhu Yang
2021-12-14 3:09 ` [PATCH v4 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms Tiezhu Yang
2021-12-14 9:32 ` [PATCH v4 0/2] MIPS: Remove some code Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).