From: Gao Xiang <gaoxiang25@huawei.com>
To: Aaron Strahlberger <aaron.strahlberger@posteo.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chao Yu <yuchao0@huawei.com>, <linux-erofs@lists.ozlabs.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<linux-kernel@i4.cs.fau.de>,
Julius Wiedmann <julius.wiedmann@fau.de>,
Dominik Huber <domi250@gmx.de>, Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH v2] staging:erofs: Fix alignment issues
Date: Wed, 12 Dec 2018 20:11:23 +0800 [thread overview]
Message-ID: <16a019d6-ccf0-b7a8-8d28-e2af9d0a76ef@huawei.com> (raw)
In-Reply-To: <20181212120053.16002-1-aaron.strahlberger@posteo.de>
Hi Aaron,
On 2018/12/12 20:00, Aaron Strahlberger wrote:
> Fix of `CHECK: Alignment should match open parenthesis` issues, reported by
> checkpatch.pl
>
> Signed-off-by: Aaron Strahlberger <aaron.strahlberger@posteo.de>
> Signed-off-by: Julius Wiedmann <julius.wiedmann@fau.de>
> Signed-off-by: Dominik Huber <domi250@gmx.de>
> ---
> drivers/staging/erofs/dir.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
> index e44ca93dcdc6..e1955703ab8f 100644
> --- a/drivers/staging/erofs/dir.c
> +++ b/drivers/staging/erofs/dir.c
> @@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
> };
>
> static int erofs_fill_dentries(struct dir_context *ctx,
> - void *dentry_blk, unsigned int *ofs,
> - unsigned int nameoff, unsigned int maxsize)
> + void *dentry_blk, unsigned int *ofs,
> + unsigned int nameoff, unsigned int maxsize)
> {
> struct erofs_dirent *de = dentry_blk;
> const struct erofs_dirent *end = dentry_blk + nameoff;
> @@ -69,8 +69,8 @@ static int erofs_fill_dentries(struct dir_context *ctx,
> #endif
>
> if (!dir_emit(ctx, de_name, de_namelen,
> - le64_to_cpu(de->nid), d_type))
> - /* stoped by some reason */
> + le64_to_cpu(de->nid), d_type))
> + /* stopped by some reason */
It seems Greg has merged part of your previous patch,
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/erofs?h=staging-testing&id=019ec6c14fbdfaeb361c84f68158fb9097f41004
Anyway, I can locally apply it by 3-way merge, and it looks good to me apart from that
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Thanks,
Gao Xiang
> return 1;
> ++de;
> *ofs += sizeof(struct erofs_dirent);
> @@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
> nameoff = le16_to_cpu(de->nameoff);
>
> if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
> - nameoff >= PAGE_SIZE)) {
> + nameoff >= PAGE_SIZE)) {
> errln("%s, invalid de[0].nameoff %u",
> - __func__, nameoff);
> + __func__, nameoff);
>
> err = -EIO;
> goto skip_this;
>
next prev parent reply other threads:[~2018-12-12 12:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:06 [PATCH] drivers: staging: erofs: Fix styling issues Aaron Strahlberger
2018-12-11 9:18 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 0/5] " Aaron Strahlberger
2018-12-11 10:54 ` [PATCH 1/5] drivers: staging: erofs: Fix alignment Aaron Strahlberger
2018-12-11 11:19 ` Gao Xiang
2018-12-11 13:00 ` Dan Carpenter
2018-12-11 10:54 ` [PATCH 2/5] drivers: staging: erofs: Fix comparison to NULL issues Aaron Strahlberger
2018-12-11 11:22 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 3/5] drivers: staging: erofs: Fix spelling issue Aaron Strahlberger
2018-12-11 11:27 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro Aaron Strahlberger
2018-12-11 11:06 ` Gao Xiang
2018-12-11 15:48 ` Joe Perches
2018-12-11 17:05 ` Gao Xiang
2018-12-12 12:02 ` [PATCH v2] staging:erofs: Remove __EROFS_BIT macro Aaron Strahlberger
2018-12-12 12:18 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 5/5] drivers: staging: erofs: Add blank line after function Aaron Strahlberger
2018-12-12 12:00 ` [PATCH v2] staging:erofs: Fix alignment issues Aaron Strahlberger
2018-12-12 12:11 ` Gao Xiang [this message]
2018-12-12 12:29 ` Gao Xiang
2018-12-11 12:51 ` [PATCH] drivers: staging: erofs: Fix styling issues Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16a019d6-ccf0-b7a8-8d28-e2af9d0a76ef@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=aaron.strahlberger@posteo.de \
--cc=devel@driverdev.osuosl.org \
--cc=domi250@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=julius.wiedmann@fau.de \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).