linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@aol.com>
To: Joe Perches <joe@perches.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>,
	Aaron Strahlberger <aaron.strahlberger@posteo.de>,
	devel@driverdev.osuosl.org,
	Julius Wiedmann <julius.wiedmann@fau.de>,
	linux-kernel@i4.cs.fau.de,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Dominik Huber <domi250@gmx.de>,
	linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro
Date: Wed, 12 Dec 2018 01:05:13 +0800	[thread overview]
Message-ID: <9d324f50-e632-c020-04b9-57269ff7bdca@aol.com> (raw)
In-Reply-To: <df69ac6826a2ec20e29d1ded7a8e7ec63c73c2c4.camel@perches.com>

Hi Joe,

On 2018/12/11 23:48, Joe Perches wrote:
> This macro is used only once and is merely obfuscation
> for that one use.  Please remove the macro and expand
> it in the one place it is used.

I am also considering to replace it in a plain way,
it will be more straight-forward to describe its on-disk format.

Thanks for your suggestion.

Thanks,
Gao Xiang

  reply	other threads:[~2018-12-11 17:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  9:06 [PATCH] drivers: staging: erofs: Fix styling issues Aaron Strahlberger
2018-12-11  9:18 ` Gao Xiang
2018-12-11 10:54   ` [PATCH 0/5] " Aaron Strahlberger
2018-12-11 10:54     ` [PATCH 1/5] drivers: staging: erofs: Fix alignment Aaron Strahlberger
2018-12-11 11:19       ` Gao Xiang
2018-12-11 13:00       ` Dan Carpenter
2018-12-11 10:54     ` [PATCH 2/5] drivers: staging: erofs: Fix comparison to NULL issues Aaron Strahlberger
2018-12-11 11:22       ` Gao Xiang
2018-12-11 10:54     ` [PATCH 3/5] drivers: staging: erofs: Fix spelling issue Aaron Strahlberger
2018-12-11 11:27       ` Gao Xiang
2018-12-11 10:54     ` [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro Aaron Strahlberger
2018-12-11 11:06       ` Gao Xiang
2018-12-11 15:48         ` Joe Perches
2018-12-11 17:05           ` Gao Xiang [this message]
2018-12-12 12:02             ` [PATCH v2] staging:erofs: Remove __EROFS_BIT macro Aaron Strahlberger
2018-12-12 12:18               ` Gao Xiang
2018-12-11 10:54     ` [PATCH 5/5] drivers: staging: erofs: Add blank line after function Aaron Strahlberger
2018-12-12 12:00   ` [PATCH v2] staging:erofs: Fix alignment issues Aaron Strahlberger
2018-12-12 12:11     ` Gao Xiang
2018-12-12 12:29       ` Gao Xiang
2018-12-11 12:51 ` [PATCH] drivers: staging: erofs: Fix styling issues Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d324f50-e632-c020-04b9-57269ff7bdca@aol.com \
    --to=hsiangkao@aol.com \
    --cc=aaron.strahlberger@posteo.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=domi250@gmx.de \
    --cc=gaoxiang25@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=julius.wiedmann@fau.de \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).