From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tejun Heo <tj@kernel.org>
Cc: Nigel Cunningham <nigel@nigelcunningham.com.au>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Jens Axboe <axboe@kernel.dk>,
tomaz.solc@tablix.org, aaron.lu@intel.com,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] libata, freezer: avoid block device removal while system is frozen
Date: Wed, 18 Dec 2013 23:04:40 +0100 [thread overview]
Message-ID: <1735137.dNmBz0IqxU@vostro.rjw.lan> (raw)
In-Reply-To: <20131218214128.GB8218@mtj.dyndns.org>
On Wednesday, December 18, 2013 04:41:28 PM Tejun Heo wrote:
> On Wed, Dec 18, 2013 at 04:39:36PM -0500, Tejun Heo wrote:
> > Yeah, we can just rip out the whole freezer support and let the
> > caller's pm notification hooks implement it by doing
> >
> > workqueue_set_max_active(wq, 0);
> > flush_workqueue(wq);
>
> Oops, the above doesn't work but I can trivially add a new interface
> for this. Something which waits for the max_active to drop below the
> newly set level before returning.
>
> workqueue_set_max_active_and_wait(wq, 0);
If you add that, I can convert the PM workqueue to using it and then
we can go through all of the existing users and make similar changes - or
just make them non-freezable if there's no good reason for freezing those
particular ones.
Thanks,
Rafael
next prev parent reply other threads:[~2013-12-18 21:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 17:49 Writeback threads and freezable Tejun Heo
2013-12-13 18:52 ` Tejun Heo
2013-12-13 20:40 ` [PATCH] libata, freezer: avoid block device removal while system is frozen Tejun Heo
2013-12-13 22:45 ` Nigel Cunningham
2013-12-13 23:07 ` Tejun Heo
2013-12-13 23:15 ` Nigel Cunningham
2013-12-14 1:55 ` Dave Chinner
2013-12-14 20:31 ` Tejun Heo
2013-12-14 20:36 ` Tejun Heo
2013-12-14 21:21 ` Nigel Cunningham
2013-12-17 2:35 ` Rafael J. Wysocki
2013-12-17 2:34 ` Rafael J. Wysocki
2013-12-17 12:34 ` Tejun Heo
2013-12-18 0:35 ` Rafael J. Wysocki
2013-12-18 11:17 ` Tejun Heo
2013-12-18 21:48 ` Rafael J. Wysocki
2013-12-18 21:39 ` Tejun Heo
2013-12-18 21:41 ` Tejun Heo
2013-12-18 22:04 ` Rafael J. Wysocki [this message]
2013-12-19 23:35 ` [PATCH wq/for-3.14 1/2] workqueue: update max_active clamping rules Tejun Heo
2013-12-20 1:26 ` Rafael J. Wysocki
2013-12-19 23:37 ` [PATCH wq/for-3.14 2/2] workqueue: implement @drain for workqueue_set_max_active() Tejun Heo
2013-12-20 1:31 ` Rafael J. Wysocki
2013-12-20 13:32 ` Tejun Heo
2013-12-20 13:56 ` Rafael J. Wysocki
2013-12-20 14:23 ` Tejun Heo
2013-12-16 12:12 ` [PATCH] libata, freezer: avoid block device removal while system is frozen Ming Lei
2013-12-16 12:45 ` Tejun Heo
2013-12-16 13:24 ` Ming Lei
2013-12-16 16:05 ` Tejun Heo
2013-12-17 2:38 ` Rafael J. Wysocki
2013-12-17 12:36 ` Tejun Heo
2013-12-18 0:23 ` Rafael J. Wysocki
2013-12-17 12:50 ` [PATCH v2] " Tejun Heo
2013-12-18 1:04 ` Rafael J. Wysocki
2013-12-18 11:08 ` Tejun Heo
2013-12-18 12:07 ` [PATCH v3] " Tejun Heo
2013-12-18 22:08 ` Rafael J. Wysocki
2013-12-19 17:24 ` Tejun Heo
2013-12-19 18:54 ` [PATCH v4] " Tejun Heo
2013-12-14 1:53 ` Writeback threads and freezable Dave Chinner
2013-12-14 17:30 ` Greg Kroah-Hartman
2013-12-14 20:23 ` Tejun Heo
2013-12-16 3:56 ` Dave Chinner
2013-12-16 12:51 ` Tejun Heo
2013-12-16 12:56 ` Tejun Heo
2013-12-18 0:35 ` Dave Chinner
2013-12-18 11:43 ` Tejun Heo
2013-12-18 22:14 ` Rafael J. Wysocki
2013-12-19 4:08 ` Dave Chinner
2013-12-19 16:24 ` Tejun Heo
2013-12-20 0:51 ` Dave Chinner
2013-12-20 14:51 ` Tejun Heo
2013-12-20 14:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1735137.dNmBz0IqxU@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aaron.lu@intel.com \
--cc=axboe@kernel.dk \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigelcunningham.com.au \
--cc=oleg@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tj@kernel.org \
--cc=tomaz.solc@tablix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).