* [PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID'
@ 2019-04-06 3:11 YueHaibing
2019-04-06 8:22 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-04-06 3:11 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: YueHaibing, devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c: In function 'rtl92e_check_adapter':
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c:36:6: warning:
variable 'VenderID' set but not used [-Wunused-but-set-variable]
u16 VenderID;
^
It's never used and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
index bab41ab7c0a5..1d992d5c4e17 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
@@ -33,12 +33,10 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev,
bool rtl92e_check_adapter(struct pci_dev *pdev, struct net_device *dev)
{
struct r8192_priv *priv = (struct r8192_priv *)rtllib_priv(dev);
- u16 VenderID;
u16 DeviceID;
u8 RevisionID;
u16 IrqLine;
- VenderID = pdev->vendor;
DeviceID = pdev->device;
RevisionID = pdev->revision;
pci_read_config_word(pdev, 0x3C, &IrqLine);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID'
2019-04-06 3:11 [PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID' YueHaibing
@ 2019-04-06 8:22 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2019-04-06 8:22 UTC (permalink / raw)
To: YueHaibing, Greg Kroah-Hartman; +Cc: devel, linux-kernel, kernel-janitors
On 4/6/2019 8:41 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.c: In function 'rtl92e_check_adapter':
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.c:36:6: warning:
> variable 'VenderID' set but not used [-Wunused-but-set-variable]
> u16 VenderID;
> ^
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
> index bab41ab7c0a5..1d992d5c4e17 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
> @@ -33,12 +33,10 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev,
> bool rtl92e_check_adapter(struct pci_dev *pdev, struct net_device *dev)
> {
> struct r8192_priv *priv = (struct r8192_priv *)rtllib_priv(dev);
> - u16 VenderID;
> u16 DeviceID;
> u8 RevisionID;
> u16 IrqLine;
>
> - VenderID = pdev->vendor;
> DeviceID = pdev->device;
> RevisionID = pdev->revision;
> pci_read_config_word(pdev, 0x3C, &IrqLine);
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-06 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 3:11 [PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID' YueHaibing
2019-04-06 8:22 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).