[PATCH] selftests/x86: Don't muck with ftrace in mpx_mini_test

[PATCH] selftests/x86: Don't muck with ftrace in mpx_mini_test

[Andy Lutomirski]

I don't know why mpx_mini_test tries to reprogram ftrace, but it
seems rude and it makes the test crash if run as non-root.  Comment
it out.

Cc: Dave Hansen <dave.hansen@intel.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 tools/testing/selftests/x86/mpx-mini-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/mpx-mini-test.c b/tools/testing/selftests/x86/mpx-mini-test.c
index 23ddd453f362..07461ce31d90 100644
--- a/tools/testing/selftests/x86/mpx-mini-test.c
+++ b/tools/testing/selftests/x86/mpx-mini-test.c
@@ -76,9 +76,9 @@ void trace_me(void)
 	write_pid_to("common_pid=", TED "exceptions/filter");
 	write_int_to("", TED "signal/enable", 1);
 	write_int_to("", TED "exceptions/enable", 1);
-*/
 	write_pid_to("", "/sys/kernel/debug/tracing/set_ftrace_pid");
 	write_int_to("", "/sys/kernel/debug/tracing/trace", 0);
+*/
 }
 
 #define test_failed() __test_failed(__FILE__, __LINE__)
-- 
2.21.0

Re: [PATCH] selftests/x86: Don't muck with ftrace in mpx_mini_test

[Dave Hansen]

On 7/3/19 11:28 AM, Andy Lutomirski wrote:
> I don't know why mpx_mini_test tries to reprogram ftrace, but it
> seems rude and it makes the test crash if run as non-root.  Comment
> it out.

Yeah, it's rude and shouldn't be enabled in the default selftest runs.

Acked-by: Dave Hansen <dave.hansen@intel.com>