From: Vlastimil Babka <vbabka@suse.cz>
To: Shakeel Butt <shakeelb@google.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: Axel Rasmussen <axelrasmussen@google.com>,
Tejun Heo <tj@kernel.org>, Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chinwen Chang <chinwen.chang@mediatek.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
David Rientjes <rientjes@google.com>,
Davidlohr Bueso <dbueso@suse.de>, Ingo Molnar <mingo@redhat.com>,
Jann Horn <jannh@google.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Michel Lespinasse <walken@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Yafang Shao <laoar.shao@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
dsahern@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jakub Kicinski <kuba@kernel.org>,
liuhangbin@gmail.com, LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints
Date: Fri, 4 Dec 2020 17:36:20 +0100 [thread overview]
Message-ID: <1eb44e95-1fae-5d64-d114-d305c9b8ef63@suse.cz> (raw)
In-Reply-To: <CALvZod5mAtes0T5DFCgjU+CKVBVOdYc=jPFHXvAU+LzDqGXomg@mail.gmail.com>
On 12/2/20 2:11 AM, Shakeel Butt wrote:
> On Tue, Dec 1, 2020 at 5:07 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>> On Tue, 1 Dec 2020 16:36:32 -0800
>> Shakeel Butt <shakeelb@google.com> wrote:
>>
>> > SGTM but note that usually Andrew squash all the patches into one
>> > before sending to Linus. If you plan to replace the path buffer with
>> > integer IDs then no need to spend time fixing buffer related bug.
>>
>> I don't think Andrew squashes all the patches. I believe he sends Linus
>> a patch series.
>
> I am talking about the patch and the following fixes to that patch.
> Those are usually squashed into one patch.
Yeah, if there's a way forward that doesn't need to construct full path on each
event and the associated complexity and just use an ID, let's convert to the ID
and squash it, for less churn. Especially if there are other existing
tracepoints that use the ID.
If there's further (somewhat orthogonal) work to make the IDs easier for
userspace, it can be added on top later, but really shouldn't need to add the
current complex solution only to remove it later?
Thanks,
Vlastimil
next prev parent reply other threads:[~2020-12-04 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 23:35 [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints Axel Rasmussen
2020-12-01 1:33 ` Shakeel Butt
2020-12-01 17:36 ` Axel Rasmussen
2020-12-01 17:56 ` Greg Thelen
2020-12-01 18:42 ` Shakeel Butt
2020-12-01 19:13 ` Axel Rasmussen
2020-12-01 20:53 ` Shakeel Butt
2020-12-02 0:15 ` Axel Rasmussen
2020-12-02 0:36 ` Shakeel Butt
2020-12-02 1:07 ` Steven Rostedt
2020-12-02 1:11 ` Shakeel Butt
2020-12-04 16:36 ` Vlastimil Babka [this message]
2020-12-04 17:46 ` Axel Rasmussen
2020-12-02 19:00 ` Tejun Heo
2020-12-02 23:23 ` Shakeel Butt
2020-12-02 23:30 ` Tejun Heo
2020-12-01 3:57 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb44e95-1fae-5d64-d114-d305c9b8ef63@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chinwen.chang@mediatek.com \
--cc=daniel.m.jordan@oracle.com \
--cc=davem@davemloft.net \
--cc=dbueso@suse.de \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gthelen@google.com \
--cc=jannh@google.com \
--cc=kuba@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuhangbin@gmail.com \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).