From: Shakeel Butt <shakeelb@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Axel Rasmussen <axelrasmussen@google.com>,
Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chinwen Chang <chinwen.chang@mediatek.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
David Rientjes <rientjes@google.com>,
Davidlohr Bueso <dbueso@suse.de>, Ingo Molnar <mingo@redhat.com>,
Jann Horn <jannh@google.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Michel Lespinasse <walken@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Steven Rostedt <rostedt@goodmis.org>,
Vlastimil Babka <vbabka@suse.cz>,
Yafang Shao <laoar.shao@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
dsahern@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jakub Kicinski <kuba@kernel.org>,
liuhangbin@gmail.com, LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints
Date: Wed, 2 Dec 2020 15:23:57 -0800 [thread overview]
Message-ID: <CALvZod4ZroEOwbiZ5aKTd28d1tva0YLWfLZTF-N-xXd_40rUsA@mail.gmail.com> (raw)
In-Reply-To: <X8fkVcfztQtX2dRT@mtj.duckdns.org>
On Wed, Dec 2, 2020 at 11:01 AM Tejun Heo <tj@kernel.org> wrote:
>
> Hello,
>
> On Tue, Dec 01, 2020 at 12:53:46PM -0800, Shakeel Butt wrote:
> > The writeback tracepoint in include/trace/events/writeback.h is
> > already using the cgroup IDs. Actually it used to use cgroup_path but
> > converted to cgroup_ino.
> >
> > Tejun, how do you use these tracepoints?
>
Thanks Tejun, I really appreciate the example you provided. I do have one query.
> There've been some changes to cgroup ids recently and now cgroup id, ino and
> its file_handle are all compatible. On 64bit ino machines, they're all the
> same and won't be reused. On 32bit ino machines, the lower 32bit of full id
> is used as ino. ino may be reused but not the full 64bit id.
__kernfs_new_node() is using idr_alloc_cyclic() which will return
32bit ID. If I am understanding this correctly the full ID is
generated similarly for 32bit and 64bit machines but for 64bit
machines the whole ID is inode number while on 32bit machines the
lower 32bits contains the inode number. Is that correct?
next prev parent reply other threads:[~2020-12-02 23:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 23:35 [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints Axel Rasmussen
2020-12-01 1:33 ` Shakeel Butt
2020-12-01 17:36 ` Axel Rasmussen
2020-12-01 17:56 ` Greg Thelen
2020-12-01 18:42 ` Shakeel Butt
2020-12-01 19:13 ` Axel Rasmussen
2020-12-01 20:53 ` Shakeel Butt
2020-12-02 0:15 ` Axel Rasmussen
2020-12-02 0:36 ` Shakeel Butt
2020-12-02 1:07 ` Steven Rostedt
2020-12-02 1:11 ` Shakeel Butt
2020-12-04 16:36 ` Vlastimil Babka
2020-12-04 17:46 ` Axel Rasmussen
2020-12-02 19:00 ` Tejun Heo
2020-12-02 23:23 ` Shakeel Butt [this message]
2020-12-02 23:30 ` Tejun Heo
2020-12-01 3:57 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod4ZroEOwbiZ5aKTd28d1tva0YLWfLZTF-N-xXd_40rUsA@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chinwen.chang@mediatek.com \
--cc=daniel.m.jordan@oracle.com \
--cc=davem@davemloft.net \
--cc=dbueso@suse.de \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gthelen@google.com \
--cc=jannh@google.com \
--cc=kuba@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuhangbin@gmail.com \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).