From: Vlastimil Babka <vbabka@suse.cz>
To: Oscar Salvador <osalvador@suse.de>, akpm@linux-foundation.org
Cc: n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] mm,hwpoison: Refactor get_any_page
Date: Wed, 25 Nov 2020 17:54:54 +0100 [thread overview]
Message-ID: <1f2561be-15bb-9c74-16e3-719ddc310cb3@suse.cz> (raw)
In-Reply-To: <20201119105716.5962-2-osalvador@suse.de>
On 11/19/20 11:57 AM, Oscar Salvador wrote:
> When we want to grab a refcount via get_any_page, we call
> __get_any_page that calls get_hwpoison_page to get the
> actual refcount.
> get_any_page is only there because we have a sort of retry
> mechanism in case the page we met is unknown to us or
> if we raced with an allocation.
>
> Also __get_any_page prints some messages about the page type
> in case the page was a free page or the page type was unknown,
> but if anything, we only need to print a message in case the
> pagetype was unknown, as that is reporting an error down the chain.
>
> Let us merge get_any_page and __get_any_page, and let the message
> be printed in soft_offline_page.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
Acked-by: Vlastimil Babka <Vbabka@suse.cz>
next prev parent reply other threads:[~2020-11-25 16:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 10:57 [PATCH 0/7] HWPoison: Refactor get page interface Oscar Salvador
2020-11-19 10:57 ` [PATCH 1/7] mm,hwpoison: Refactor get_any_page Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:54 ` Vlastimil Babka [this message]
2020-11-19 10:57 ` [PATCH 2/7] mm,hwpoison: Drop pfn parameter Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:55 ` Vlastimil Babka
2020-11-19 10:57 ` [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED Oscar Salvador
2020-11-25 18:20 ` Vlastimil Babka
2020-12-01 11:35 ` Oscar Salvador
2020-12-04 17:25 ` Vlastimil Babka
2020-12-05 15:34 ` Oscar Salvador
2020-12-07 2:34 ` HORIGUCHI NAOYA(堀口 直也)
2020-12-07 7:24 ` Oscar Salvador
2020-11-19 10:57 ` [PATCH 4/7] mm,hwpoison: remove MF_COUNT_INCREASED Oscar Salvador
2020-11-19 10:57 ` [PATCH 5/7] mm,hwpoison: remove flag argument from soft offline functions Oscar Salvador
2020-11-19 10:57 ` [PATCH 6/7] mm,hwpoison: Disable pcplists before grabbing a refcount Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-26 13:45 ` Vlastimil Babka
2020-11-28 0:51 ` Andrew Morton
2020-11-19 10:57 ` [PATCH 7/7] mm,hwpoison: Remove drain_all_pages from shake_page Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-26 13:52 ` Vlastimil Babka
2020-11-27 7:20 ` Oscar Salvador
2020-12-02 13:34 ` [PATCH 0/7] HWPoison: Refactor get page interface Qian Cai
2020-12-02 13:41 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2561be-15bb-9c74-16e3-719ddc310cb3@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).