From: Oscar Salvador <osalvador@suse.de>
To: Qian Cai <qcai@redhat.com>
Cc: akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] HWPoison: Refactor get page interface
Date: Wed, 2 Dec 2020 14:41:39 +0100 [thread overview]
Message-ID: <20201202134131.GA8110@linux> (raw)
In-Reply-To: <1ba3d19ab0629e549519fb94b73cabb0b392fb2a.camel@redhat.com>
On Wed, Dec 02, 2020 at 08:34:57AM -0500, Qian Cai wrote:
> On Thu, 2020-11-19 at 11:57 +0100, Oscar Salvador wrote:
> > Hi,
> >
> > following up on previous fix-ups an refactors, this patchset simplifies
> > the get page interface and removes the MF_COUNT_INCREASED trick we have
> > for soft offline.
>
> Well, the madvise() EIO is back. I don't understand why we can't test it on a
> NUMA system before posting this over and over again.
>
> # git clone https://e.coding.net/cailca/linux/mm
> # cd mm; make
> # ./ranbug 1
> - start: migrate_huge_offline
> - use NUMA nodes 0,3.
> - mmap and free 8388608 bytes hugepages on node 0
> - mmap and free 8388608 bytes hugepages on node 3
> madvise: Input/output error
I tried it out myself enlarging the window race artificially but I was not able
to get -EIO anymore.
But as Vlastimil pointed out in the respective patch, it is better to keep the
page pinned for madvise.
I am planning to re-post leaving out the patches that remove the pinning.
Anyway, thanks for the report.
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2020-12-02 13:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 10:57 [PATCH 0/7] HWPoison: Refactor get page interface Oscar Salvador
2020-11-19 10:57 ` [PATCH 1/7] mm,hwpoison: Refactor get_any_page Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:54 ` Vlastimil Babka
2020-11-19 10:57 ` [PATCH 2/7] mm,hwpoison: Drop pfn parameter Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:55 ` Vlastimil Babka
2020-11-19 10:57 ` [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED Oscar Salvador
2020-11-25 18:20 ` Vlastimil Babka
2020-12-01 11:35 ` Oscar Salvador
2020-12-04 17:25 ` Vlastimil Babka
2020-12-05 15:34 ` Oscar Salvador
2020-12-07 2:34 ` HORIGUCHI NAOYA(堀口 直也)
2020-12-07 7:24 ` Oscar Salvador
2020-11-19 10:57 ` [PATCH 4/7] mm,hwpoison: remove MF_COUNT_INCREASED Oscar Salvador
2020-11-19 10:57 ` [PATCH 5/7] mm,hwpoison: remove flag argument from soft offline functions Oscar Salvador
2020-11-19 10:57 ` [PATCH 6/7] mm,hwpoison: Disable pcplists before grabbing a refcount Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-26 13:45 ` Vlastimil Babka
2020-11-28 0:51 ` Andrew Morton
2020-11-19 10:57 ` [PATCH 7/7] mm,hwpoison: Remove drain_all_pages from shake_page Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-26 13:52 ` Vlastimil Babka
2020-11-27 7:20 ` Oscar Salvador
2020-12-02 13:34 ` [PATCH 0/7] HWPoison: Refactor get page interface Qian Cai
2020-12-02 13:41 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202134131.GA8110@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qcai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).