2.4.5-ac12: 3c590.c: Warning about 'nopnp' parameter

2.4.5-ac12: 3c590.c: Warning about 'nopnp' parameter

[Dieter Nützel]

Taken from boot.msg:

Setting up network device eth1
insmod: Warning: /lib/modules/2.4.5-ac12/kernel/drivers/net/3c509.o symbol 
for parameter nopnp not found
 done

I've tried with and without ISA PNP support.

Any hints?

Thanks,
	Dieter

Re: 2.4.5-ac12: 3c590.c: Warning about 'nopnp' parameter

[Keith Owens]

On Mon, 11 Jun 2001 04:35:42 +0200, 
Dieter =?iso-8859-1?q?N=FCtzel?= <Dieter.Nuetzel@hamburg.de> wrote:
>insmod: Warning: /lib/modules/2.4.5-ac12/kernel/drivers/net/3c509.o symbol 
>for parameter nopnp not found

MODULE_PARM(nopnp) is in open code but the declaration of nopnp is
wrapped in #ifdef CONFIG_ISAPNP.  The module parm needs to be wrapped
in #ifdef CONFIG_ISAPNP as well.  Against 2.4.5-ac13.

Index: 5.35/drivers/net/3c509.c
--- 5.35/drivers/net/3c509.c Sat, 09 Jun 2001 17:17:16 +1000 kaos (linux-2.4/l/c/31_3c509.c 1.2.1.6 644)
+++ 5.35(w)/drivers/net/3c509.c Mon, 11 Jun 2001 14:47:01 +1000 kaos (linux-2.4/l/c/31_3c509.c 1.2.1.6 644)
@@ -1014,8 +1014,10 @@ MODULE_PARM_DESC(debug, "EtherLink III d
 MODULE_PARM_DESC(irq, "EtherLink III IRQ number(s) (assigned)");
 MODULE_PARM_DESC(xcvr,"EtherLink III tranceiver(s) (0=internal, 1=external)");
 MODULE_PARM_DESC(max_interrupt_work, "EtherLink III maximum events handled per interrupt");
+#ifdef CONFIG_ISAPNP
 MODULE_PARM(nopnp, "i");
 MODULE_PARM_DESC(nopnp, "EtherLink III disable ISA PnP support (0-1)");
+#endif	/* CONFIG_ISAPNP */
 
 int
 init_module(void)

Re: 2.4.5-ac12: 3c590.c: Warning about 'nopnp' parameter

[Dieter Nützel]

Am Montag, 11. Juni 2001 06:48 schrieb Keith Owens:
> On Mon, 11 Jun 2001 04:35:42 +0200,
>
> Dieter =?iso-8859-1?q?N=FCtzel?= <Dieter.Nuetzel@hamburg.de> wrote:
> >insmod: Warning: /lib/modules/2.4.5-ac12/kernel/drivers/net/3c509.o symbol
> >for parameter nopnp not found
>
> MODULE_PARM(nopnp) is in open code but the declaration of nopnp is
> wrapped in #ifdef CONFIG_ISAPNP.  The module parm needs to be wrapped
> in #ifdef CONFIG_ISAPNP as well.  Against 2.4.5-ac13.
>
> Index: 5.35/drivers/net/3c509.c
> --- 5.35/drivers/net/3c509.c Sat, 09 Jun 2001 17:17:16 +1000 kaos
> (linux-2.4/l/c/31_3c509.c 1.2.1.6 644) +++ 5.35(w)/drivers/net/3c509.c Mon,
> 11 Jun 2001 14:47:01 +1000 kaos (linux-2.4/l/c/31_3c509.c 1.2.1.6 644) @@
> -1014,8 +1014,10 @@ MODULE_PARM_DESC(debug, "EtherLink III d
>  MODULE_PARM_DESC(irq, "EtherLink III IRQ number(s) (assigned)");
>  MODULE_PARM_DESC(xcvr,"EtherLink III tranceiver(s) (0=internal,
> 1=external)"); MODULE_PARM_DESC(max_interrupt_work, "EtherLink III maximum
> events handled per interrupt"); +#ifdef CONFIG_ISAPNP
>  MODULE_PARM(nopnp, "i");
>  MODULE_PARM_DESC(nopnp, "EtherLink III disable ISA PnP support (0-1)");
> +#endif	/* CONFIG_ISAPNP */
>
>  int
>  init_module(void)

It calmed it.

Thanks,
	Dieter