From: Andries Brouwer <aebr@win.tue.nl>
To: "Joseph Malicki" <jmalicki@starbak.net>
Cc: "Patrick J. LoPresti" <patl@curl.com>, <linux-kernel@vger.kernel.org>
Subject: Re: close return value
Date: Sat, 20 Jul 2002 16:42:17 +0200 [thread overview]
Message-ID: <20020720144217.GA2259@win.tue.nl> (raw)
In-Reply-To: <015401c22f40$c4471380$da5b903f@starbak.net>
On Fri, Jul 19, 2002 at 12:24:33PM -0400, Joseph Malicki wrote:
> Those mistakes are your ignorance. The manpage is wrong.
> It does return -1 on error.
Yes, you are right (or, at least, "a negative value").
Now you deserve a beating for noting that there is a bug on
a man page without submitting a correction, or at least
telling the maintainer. (Yes, that's me.)
> Sure, if you require an event to be successful to continue you should always
> check it. And yes, it's nice to print an error message on close sometimes,
> if something is critical. But the question to ask is what you would
> actually _DO_ about an error... if the answer is nothing,
> then why check it?
But here you are wrong. Even if the program doesn't know what to do,
the user will want to know about it. If I make a backup and some error
occurs then I would be very unhappy if the program were silent about it.
Andries
aeb@cwi.nl
next prev parent reply other threads:[~2002-07-20 14:39 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020712162306$aa7d@traf.lcs.mit.edu>
[not found] ` <mit.lcs.mail.linux-kernel/20020712162306$aa7d@traf.lcs.mit.edu>
2002-07-15 15:22 ` [ANNOUNCE] Ext3 vs Reiserfs benchmarks Patrick J. LoPresti
2002-07-15 17:31 ` Chris Mason
2002-07-15 18:33 ` Matthias Andree
[not found] ` <20020715173337$acad@traf.lcs.mit.edu>
[not found] ` <mit.lcs.mail.linux-kernel/20020715173337$acad@traf.lcs.mit.edu>
2002-07-15 19:13 ` Patrick J. LoPresti
2002-07-15 20:55 ` Matthias Andree
2002-07-15 21:23 ` Patrick J. LoPresti
2002-07-15 21:38 ` Thunder from the hill
2002-07-16 12:31 ` Matthias Andree
2002-07-16 15:53 ` Thunder from the hill
2002-07-16 19:26 ` Matthias Andree
2002-07-16 19:38 ` Thunder from the hill
2002-07-16 23:22 ` close return value (was Re: [ANNOUNCE] Ext3 vs Reiserfs benchmarks) Zack Weinberg
2002-07-17 1:03 ` Alan Cox
2002-07-16 23:52 ` close return value David S. Miller
2002-07-17 1:35 ` Alan Cox
2002-07-17 0:20 ` David S. Miller
2002-07-17 1:05 ` Linus Torvalds
2002-07-17 1:05 ` David S. Miller
2002-07-17 1:23 ` Linus Torvalds
2002-07-17 11:51 ` Matthias Andree
2002-07-17 17:23 ` Andries Brouwer
2002-07-20 8:00 ` Florian Weimer
2002-07-20 16:45 ` Linus Torvalds
2002-07-26 0:06 ` EFAULT vs. SIGSEGV [was Re: close return value] Pavel Machek
2002-07-26 14:01 ` (no subject) Alexis Deruelle
[not found] ` <mailman.1026868201.10433.linux-kernel2news@redhat.com>
2002-07-18 0:01 ` close return value Pete Zaitcev
2002-07-18 0:10 ` Thunder from the hill
[not found] ` <mit.lcs.mail.linux-kernel/200207180001.g6I015f02681@devserv.devel.redhat.com>
2002-07-18 14:42 ` Patrick J. LoPresti
2002-07-18 15:13 ` Richard B. Johnson
2002-07-18 15:32 ` Sandy Harris
2002-07-18 23:47 ` Albert D. Cahalan
2002-07-19 16:12 ` Patrick J. LoPresti
2002-07-19 16:24 ` Joseph Malicki
2002-07-19 18:48 ` Patrick J. LoPresti
2002-07-19 19:25 ` Lars Marowsky-Bree
2002-07-19 19:30 ` Arnaldo Carvalho de Melo
2002-07-19 19:45 ` Joseph Malicki
2002-07-19 19:55 ` Arnaldo Carvalho de Melo
2002-07-20 18:25 ` Bernd Eckenfels
2002-07-20 23:06 ` Sandy Harris
2002-07-20 14:42 ` Andries Brouwer [this message]
2002-07-18 20:09 ` Hildo.Biersma
2002-07-18 23:55 ` Pete Zaitcev
2002-07-19 11:31 ` Hildo.Biersma
2002-07-19 16:16 ` Pete Zaitcev
2002-07-23 22:19 ` Bill Davidsen
2002-07-17 0:10 ` close return value (was Re: [ANNOUNCE] Ext3 vs Reiserfs benchmarks) Zack Weinberg
2002-07-17 1:45 ` Alan Cox
2002-07-17 18:24 ` Zack Weinberg
2002-07-22 16:42 ` Rogier Wolff
2002-07-17 8:00 ` Lars Marowsky-Bree
2002-07-17 15:49 ` Thunder from the hill
2002-07-17 2:22 ` Elladan
2002-07-17 2:54 ` Thunder from the hill
2002-07-17 3:00 ` Elladan
2002-07-17 3:10 ` Thunder from the hill
2002-07-17 3:31 ` Elladan
2002-07-17 4:17 ` Stevie O
2002-07-17 4:38 ` Elladan
2002-07-17 14:39 ` Andreas Schwab
2002-07-17 16:49 ` Elladan
2002-07-17 17:43 ` Linus Torvalds
2002-07-17 22:07 ` Elladan
2002-07-18 9:48 ` Ketil Froyn
2002-07-17 17:17 ` Andries Brouwer
2002-07-17 17:51 ` Richard Gooch
2002-07-17 7:34 ` close return value (was Re: [ANNOUNCE] Ext3 vs Reiserfs benchmarks Kai Henningsen
2002-07-15 21:59 ` Ketil Froyn
2002-07-15 23:08 ` Matti Aarnio
2002-07-16 12:33 ` Matthias Andree
2002-07-15 22:55 ` Alan Cox
2002-07-15 21:58 ` Matthias Andree
2002-07-15 21:14 ` Chris Mason
2002-07-15 21:31 ` Patrick J. LoPresti
2002-07-15 22:12 ` Richard A Nelson
2002-07-16 1:02 ` Lawrence Greenfield
[not found] ` <mit.lcs.mail.linux-kernel/200207160102.g6G12BiH022986@lin2.andrew.cmu.edu>
2002-07-16 1:43 ` Patrick J. LoPresti
2002-07-16 1:56 ` Thunder from the hill
2002-07-16 12:47 ` Matthias Andree
2002-07-16 21:09 ` James Antill
2002-07-16 12:35 ` Matthias Andree
2002-07-16 7:07 ` Dax Kelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020720144217.GA2259@win.tue.nl \
--to=aebr@win.tue.nl \
--cc=jmalicki@starbak.net \
--cc=linux-kernel@vger.kernel.org \
--cc=patl@curl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).