From: Andreas Gietl <Listen@e-admin.de>
To: Bernhard Kaindl <kaindl@telering.at>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.4-rc1] fix side effects of the kmod/ptrace secfix
Date: Fri, 25 Apr 2003 16:40:22 +0200 [thread overview]
Message-ID: <200304251640.22021.Listen@e-admin.de> (raw)
In-Reply-To: <Pine.LNX.4.53.0304251215200.2582@hase.a11.local>
On Friday 25 April 2003 12:40, Bernhard Kaindl wrote:
> On Fri, 25 Apr 2003, Andreas Gietl wrote:
> > > system monitoring stuff this way(I've even heard shutdown is affected)
> >
> > i can confirm that shutdown (halt|reboot) does not work on my
> > 2.4.21-rc1-ac1 boxes. (gentoo + redhat).
>
> Thanks for the info!
>
> > But your patch does not seem to fix it.
>
> Very interesting also, the two liner adressed only the well-known problems.
> To fix the other not so well-known side effects, a real cleanup is the way
> to go.
>
> Can you try the attached cleanup patch instead of the two-liner?
>
> It's an inital cleanup and should fix the other side effects which
> I described in my mails.
>
> Bernhard Kaindl
>
> PS: If either patch is applied correctly, this
>
> su guest -c 'ps $PPID;wc -m </proc/$PPID/cmdline'
>
> should give:
>
> PID TTY STAT TIME COMMAND
> 2452 pts/2 S 0:00 su bin -c ps $PPID;wc -m </proc/$PPID/cmdline
> 46
it shows:
PID TTY STAT TIME COMMAND
2092 ttyp0 S 0:00 su guest -c ps $PPID;wc -m </proc/$PPID/cmdline
0
but cat shows:
su guest -c 'ps $PPID; cat /proc/$PPID/cmdline'
PID TTY STAT TIME COMMAND
2144 ttyp0 S 0:00 su guest -c ps $PPID; cat /proc/$PPID/cmdline
suguest-cps $PPID; cat /proc/$PPID/cmdline
what happened?
>
> If it does not, access_process_vm is not fixed properly.
>
> Second, calling this as root:
>
> strace -fewrite su -c /bin/echo 2>&1 | grep pid
>
> should give:
>
> [pid 2599] --- SIGSTOP (Stopped (signal)) @ 0 (0) ---
> [pid 2599] write(1, "\n", 1
it shows:
localhost root # strace -fewrite su -c /bin/echo 2>&1 | grep pid
[pid 2159] write(1, "\n", 1
>
> If it does not, ptrace_check_attach is not fixed properly.
>
> (These are only the checks for the well known side
> effects which should be fixed even with the short
> is_dumpable() -> task_dumpable patch.)
Looks like my results are slightly diffent, Does this mean i did not apply the
patch correctly? I applied it twice manually, because patch did not succeed
and compiled the kernel 3 times...
--
e-admin internet gmbh
Andreas Gietl tel +49 941 3810884
Ludwig-Thoma-Strasse 35 fax +49 89 244329104
93051 Regensburg mobil +49 171 6070008
PGP/GPG-Key unter http://www.e-admin.de/gpg.html
next prev parent reply other threads:[~2003-04-25 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 22:37 [PATCH][2.4+ptrace] fix side effects of the kmod/ptrace secfix Andreas Gietl
2003-04-25 10:40 ` [PATCH][2.4-rc1] " Bernhard Kaindl
2003-04-25 14:40 ` Andreas Gietl [this message]
2003-04-25 14:30 ` Bernhard Kaindl
2003-04-26 16:58 ` Andreas Gietl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304251640.22021.Listen@e-admin.de \
--to=listen@e-admin.de \
--cc=kaindl@telering.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).