From: Bernhard Kaindl <kaindl@telering.at>
To: Andreas Gietl <Listen@e-admin.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.4-rc1] fix side effects of the kmod/ptrace secfix
Date: Fri, 25 Apr 2003 16:30:54 +0200 [thread overview]
Message-ID: <Pine.LNX.4.53.0304251607540.26723@hase.a11.local> (raw)
In-Reply-To: <200304251640.22021.Listen@e-admin.de>
On Fri, 25 Apr 2003, Andreas Gietl wrote:
>
> it shows:
> PID TTY STAT TIME COMMAND
> 2092 ttyp0 S 0:00 su guest -c ps $PPID;wc -m </proc/$PPID/cmdline
> 0
Ah ok, I tested this with LC_CTYPE=de_DE.UTF-8, in this case wc has
to read the contents of the file. When a single-byte locale is used,
wc just does fstat64() to get the file size(which returns 0 for the file).
> but cat shows:
> su guest -c 'ps $PPID; cat /proc/$PPID/cmdline'
> PID TTY STAT TIME COMMAND
> 2144 ttyp0 S 0:00 su guest -c ps $PPID; cat /proc/$PPID/cmdline
> suguest-cps $PPID; cat /proc/$PPID/cmdline
>
> what happened?
This is ok, access_proces_vm() is working.
> > [pid 2599] --- SIGSTOP (Stopped (signal)) @ 0 (0) ---
> > [pid 2599] write(1, "\n", 1
>
> it shows:
> localhost root # strace -fewrite su -c /bin/echo 2>&1 | grep pid
> [pid 2159] write(1, "\n", 1
Looks ok also, the task->mm->dumpable check is removed from prace_check_attach
> Looks like my results are slightly diffent, Does this mean i did not apply the
> patch correctly? I applied it twice manually, because patch did not succeed
The above shows that at least the two-liner task_dumpable diff is applied.
> and compiled the kernel 3 times...
Sorry for the different output, I should have made my tests safer against
system variants. It should have applied clean, maybe some white space issue
or so, I'll check it. shutdown didn't change? What does it on your system?
Bernd
next prev parent reply other threads:[~2003-04-25 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 22:37 [PATCH][2.4+ptrace] fix side effects of the kmod/ptrace secfix Andreas Gietl
2003-04-25 10:40 ` [PATCH][2.4-rc1] " Bernhard Kaindl
2003-04-25 14:40 ` Andreas Gietl
2003-04-25 14:30 ` Bernhard Kaindl [this message]
2003-04-26 16:58 ` Andreas Gietl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.53.0304251607540.26723@hase.a11.local \
--to=kaindl@telering.at \
--cc=Listen@e-admin.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).