From: Con Kolivas <kernel@kolivas.org>
To: linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] O11int for interactivity
Date: Wed, 30 Jul 2003 11:08:53 +1000 [thread overview]
Message-ID: <200307301108.53904.kernel@kolivas.org> (raw)
In-Reply-To: <200307301055.23950.kernel@kolivas.org>
On Wed, 30 Jul 2003 10:55, Con Kolivas wrote:
> On Wed, 30 Jul 2003 10:38, Con Kolivas wrote:
> > Update to the interactivity patches. Not a massive improvement but
> > more smoothing of the corners.
>
> Woops my bad. Seems putting things even at the start of the expired array
> can induce a corner case. Will post an O11.1 in a few mins to back out that
> part.
Here is O11.1int which backs out that part. This was only of minor help
anyway so backing it out still makes the other O11 changes worthwhile.
A full O11.1 patch against 2.6.0-test2 is available on my website.
--- linux-2.6.0-test2-mm1/kernel/sched.c 2003-07-30 10:54:54.000000000 +1000
+++ linux-2.6.0-test2mm1O11/kernel/sched.c 2003-07-30 10:46:43.000000000 +1000
@@ -310,14 +310,6 @@ static inline void enqueue_task(struct t
p->array = array;
}
-static inline void enqueue_head_task(struct task_struct *p, prio_array_t *array)
-{
- list_add(&p->run_list, array->queue + p->prio);
- __set_bit(p->prio, array->bitmap);
- array->nr_active++;
- p->array = array;
-}
-
/*
* effective_prio - return the priority that is based on the static
* priority but is modified by bonuses/penalties.
@@ -1305,13 +1297,10 @@ void scheduler_tick(int user_ticks, int
* run out of sleep_avg to be expired, and when they
* do they are put at the start of the expired array
*/
- if (unlikely(p->interactive_credit)){
- if (p->sleep_avg){
- enqueue_task(p, rq->active);
- goto out_unlock;
- }
- enqueue_head_task(p, rq->expired);
- } else
+ if (unlikely(p->interactive_credit && p->sleep_avg)){
+ enqueue_task(p, rq->active);
+ goto out_unlock;
+ }
enqueue_task(p, rq->expired);
} else
enqueue_task(p, rq->active);
next prev parent reply other threads:[~2003-07-30 1:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-30 0:38 [PATCH] O11int for interactivity Con Kolivas
2003-07-30 0:55 ` Con Kolivas
2003-07-30 1:08 ` Con Kolivas [this message]
2003-07-31 13:55 ` Szonyi Calin
2003-07-31 13:56 ` Con Kolivas
2003-07-31 15:21 ` Måns Rullgård
2003-07-31 21:38 ` William Lee Irwin III
2003-07-31 22:01 ` Robert Love
2003-07-30 8:29 ` Felipe Alfaro Solana
2003-07-30 8:43 ` Marc-Christian Petersen
2003-07-30 9:38 ` Con Kolivas
2003-07-30 9:45 ` Marc-Christian Petersen
2003-07-30 12:56 ` Felipe Alfaro Solana
2003-07-30 13:14 ` Wade
2003-07-31 21:43 ` William Lee Irwin III
2003-07-31 21:55 ` William Lee Irwin III
2003-08-01 10:44 ` Marc-Christian Petersen
2003-08-02 21:27 ` Marc-Christian Petersen
2003-08-02 22:55 ` William Lee Irwin III
2003-08-02 23:19 ` Marc-Christian Petersen
2003-08-04 19:06 ` Marc-Christian Petersen
2003-08-04 19:53 ` William Lee Irwin III
2003-08-05 0:56 ` Nick Piggin
2003-08-05 2:41 ` William Lee Irwin III
2003-08-05 3:07 ` Nick Piggin
2003-08-05 3:13 ` William Lee Irwin III
2003-08-05 3:23 ` Nick Piggin
2003-08-05 3:31 ` William Lee Irwin III
2003-08-05 3:38 ` Nick Piggin
2003-08-05 4:54 ` Valdis.Kletnieks
2003-08-05 5:02 ` William Lee Irwin III
2003-08-05 5:55 ` Andrew Morton
2003-08-05 7:11 ` Nick Piggin
2003-08-05 17:00 ` Martin Josefsson
2003-07-30 8:41 ` Felipe Alfaro Solana
2003-07-30 9:35 ` Con Kolivas
2003-07-30 15:33 ` Apurva Mehta
2003-07-31 16:58 ` Moritz Muehlenhoff
2003-07-30 10:31 Voluspa
2003-07-30 10:51 ` Con Kolivas
2003-07-30 11:20 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307301108.53904.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).