From: Adrian Bunk <bunk@fs.tum.de>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.4.22-pre10-ac1: fix tp600.c compile warning
Date: Sun, 3 Aug 2003 12:57:07 +0200 [thread overview]
Message-ID: <20030803105707.GL16426@fs.tum.de> (raw)
In-Reply-To: <200308012216.h71MGLe31285@devserv.devel.redhat.com>
I got the following compile warning in 2.4.22-pre10-ac1:
<-- snip -->
...
gcc -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.22-pre10-ac1-full/inclu
de -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -iwithprefix
include -DKBUILD_BASENAME=tp600 -c -o tp600.o tp600.c
tp600.c: In function `h2999_cleanup':
tp600.c:417: warning: control reaches end of non-void function
...
<-- snip -->
Since the only caller of this function doesn't check the return value, I
assume the following patch might be correct?
--- linux-2.4.22-pre10-ac1-full/drivers/hotplug/tp600.c~ 2003-08-02 01:44:02.000000000 +0200
+++ linux-2.4.22-pre10-ac1-full/drivers/hotplug/tp600.c 2003-08-02 23:13:34.000000000 +0200
@@ -402,7 +402,7 @@
* Unregister and free up all of our slots
*/
-static int __devinit h2999_cleanup(struct h2999_dev *dev)
+static void __devinit h2999_cleanup(struct h2999_dev *dev)
{
struct h2999_slot *s;
int slot;
I've tested the compilation with 2.4.22-pre10-ac1.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2003-08-03 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-01 22:16 Linux 2.4.22-pre10-ac1 Alan Cox
2003-08-02 4:09 ` Barry K. Nathan
2003-08-02 6:37 ` Manuel Estrada Sainz
2003-08-02 9:23 ` Marcel Holtmann
2003-08-02 9:41 ` Manuel Estrada Sainz
2003-08-02 9:57 ` Marcel Holtmann
2003-08-02 12:29 ` Alan Cox
2003-08-02 13:42 ` Marcel Holtmann
2003-08-10 22:34 ` Manuel Estrada Sainz
2003-08-03 10:57 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030803105707.GL16426@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).