linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manuel Estrada Sainz <ranty@debian.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alan Cox <alan@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.22-pre10-ac1
Date: Mon, 11 Aug 2003 00:34:21 +0200	[thread overview]
Message-ID: <20030810223421.GA14873@ranty.pantax.net> (raw)
In-Reply-To: <1059831754.22190.102.camel@pegasus>

On Sat, Aug 02, 2003 at 03:42:27PM +0200, Marcel Holtmann wrote:
> Hi Alan,
> 
> > > not quite true. If hotplug is not enabled it tells the driver that the
> > > firmware can't be loaded. It is the same if hotplug_path is zero, or you
> > 
> > The ifdef should be there, or firmware should depend on hotplug, and
> > probably the firmware users should also depend on hotplug
> 
> I definitively prefer the #ifdef, because the firmware loader should 
> automaticly selected and compiled if a driver needs it. But let a driver
> depend on hotplug can not be the solution, because some drivers maybe
> also work if the firmware loading fails.

 I don't find it necessary, but if you have so much interest, you have my
 blessing.

 Though I would instead put the #ifdef's in "linux/firmware.h" providing
 dummy inlines. Having to load a useless firmware_class.o seams a little
 overkill, and that way you also make it possible to compile
 request_firmware dependent code without CONFIG_FW_LOADER.

 Oh, and feel free to do the same for the 2.6 series :-)

 Have a nice day

 	Manuel

-- 
--- Manuel Estrada Sainz <ranty@debian.org>
                         <ranty@bigfoot.com>
			 <ranty@users.sourceforge.net>
------------------------ <manuel.estrada@hispalinux.es> -------------------
Let us have the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.

  reply	other threads:[~2003-08-10 22:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-01 22:16 Linux 2.4.22-pre10-ac1 Alan Cox
2003-08-02  4:09 ` Barry K. Nathan
2003-08-02  6:37   ` Manuel Estrada Sainz
2003-08-02  9:23     ` Marcel Holtmann
2003-08-02  9:41       ` Manuel Estrada Sainz
2003-08-02  9:57         ` Marcel Holtmann
2003-08-02 12:29           ` Alan Cox
2003-08-02 13:42             ` Marcel Holtmann
2003-08-10 22:34               ` Manuel Estrada Sainz [this message]
2003-08-03 10:57 ` [patch] 2.4.22-pre10-ac1: fix tp600.c compile warning Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030810223421.GA14873@ranty.pantax.net \
    --to=ranty@debian.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).