From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6 - sysfs sensor nameing inconsistency
Date: Mon, 18 Aug 2003 20:49:57 +0400 [thread overview]
Message-ID: <200308182049.57093.arvidjaar@mail.ru> (raw)
In-Reply-To: <20030816165016.GE9735@kroah.com>
On Saturday 16 August 2003 20:50, Greg KH wrote:
> > > I like this idea, but now that the name logic has changed in the i2c
> > > code, care to re-do this patch? Just set the name field instead of
> > > creating a new file in sysfs.
> >
> > something like attached patch? I like it as well :)
>
> Why rename local variables? Your patch would be a lot smaller if you
> just keep the same local name variable, and fix up the name strings.
>
To make it clear for anyone porting other drivers that we are using type_name
and not client_name or whatever. In 2.4 every driver have both; mixing name,
type_name and client_name will just add to confusion.
I will redo patch if you insist but I really prefer having things consistent
if possible.
thank you
-andrey
next prev parent reply other threads:[~2003-08-18 16:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-15 18:14 2.6 - sysfs sensor nameing inconsistency Andrey Borzenkov
2003-07-15 20:18 ` Greg KH
2003-07-26 18:00 ` Andrey Borzenkov
2003-08-15 20:51 ` Greg KH
2003-08-16 15:38 ` Andrey Borzenkov
2003-08-16 16:50 ` Greg KH
2003-08-18 16:49 ` Andrey Borzenkov [this message]
2003-08-18 21:31 ` Greg KH
2003-08-19 19:19 ` Andrey Borzenkov
2003-08-19 19:45 ` Greg KH
2003-08-31 16:25 ` Andrey Borzenkov
2003-09-22 22:29 ` Greg KH
2003-11-02 18:50 ` Andrey Borzenkov
2003-07-27 4:42 Margit Schubert-While
2003-07-27 6:23 Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308182049.57093.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).