From: Greg KH <greg@kroah.com>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: 2.6 - sysfs sensor nameing inconsistency
Date: Mon, 22 Sep 2003 15:29:10 -0700 [thread overview]
Message-ID: <20030922222910.GA306@kroah.com> (raw)
In-Reply-To: <200308312025.41472.arvidjaar@mail.ru>
On Sun, Aug 31, 2003 at 08:25:41PM +0400, Andrey Borzenkov wrote:
> On Tuesday 19 August 2003 23:45, Greg KH wrote:
> > That's what you are going to have to set the name file to in the
> > i2c_client structure, much like your patch did. Then look at the
> > different name files in each device directory to see what kind of device
> > it is (chip, subclient, etc.)
> >
>
> OK attached patch sets all names to just chip name for chips themselves and
> "chipname subclient" when subclient ios registered.
Thanks, I've applied this and will send it off to Linus in a bit.
> > > 3. libsensors asks for hysteresis value. This one does not exist in sysfs
> > > (so all temp readings fail). Is it emulated by kernel or read off chip?
> >
> > The kernel is exporting all of the info that it knows about through
> > sysfs.
>
> it just arbitrarily (re-)names them. "min" is not hysteresis; name is badly
> chosen.
Do you have a proposed change to the current
Documentation/i2c/sysfs-interface document? If you can think of better
names that make more sense, I'd be glad to change things to make it
easier.
> [...]
> > > 4. I do not have the slightest idea how ISA adapters look like in sysfs
> > > and where they are located. Anyone can give me example?
> >
> > They show up on the legacy bus:
> >
> > $ tree /sys/class/i2c-adapter/i2c-1/
> > /sys/class/i2c-adapter/i2c-1/
> >
> > |-- device -> ../../../devices/legacy/i2c-1
> >
>
> This does not help much. Libsensors expects as adapter identification either
> "i2c-N" or "isa". If I set it to "isa" I do not have any way to determine
> sysfs path except by rescanning /sys/class/i2c-adapter every time. Having
> /sys/class/i2-adapter/isa/... would be better, apparently it is assumed that
> only one such adapter can exist.
No, we internally do not differentiate between isa and non-isa adapters,
so why should we force that on the user? They work the same as far as
users notice, and now we are consistant in our naming.
thanks,
greg k-h
next prev parent reply other threads:[~2003-09-22 22:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-15 18:14 2.6 - sysfs sensor nameing inconsistency Andrey Borzenkov
2003-07-15 20:18 ` Greg KH
2003-07-26 18:00 ` Andrey Borzenkov
2003-08-15 20:51 ` Greg KH
2003-08-16 15:38 ` Andrey Borzenkov
2003-08-16 16:50 ` Greg KH
2003-08-18 16:49 ` Andrey Borzenkov
2003-08-18 21:31 ` Greg KH
2003-08-19 19:19 ` Andrey Borzenkov
2003-08-19 19:45 ` Greg KH
2003-08-31 16:25 ` Andrey Borzenkov
2003-09-22 22:29 ` Greg KH [this message]
2003-11-02 18:50 ` Andrey Borzenkov
2003-07-27 4:42 Margit Schubert-While
2003-07-27 6:23 Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030922222910.GA306@kroah.com \
--to=greg@kroah.com \
--cc=arvidjaar@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).