linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Patrick Mochel <mochel@osdl.org>,
	torvalds@osdl.org, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?
Date: Tue, 2 Sep 2003 19:41:26 +0200	[thread overview]
Message-ID: <20030902174126.GB14209@suse.de> (raw)
In-Reply-To: <20030901120208.GC1358@openzaurus.ucw.cz>

On Mon, Sep 01 2003, Pavel Machek wrote:
> Hi!
> 
> > I think we need to expand the platform device support to include the
> > notion of platform drivers.  For example:
> > 
> > 	struct platform_driver {
> > 		int (*probe)(struct platform_device *);
> > 		int (*remove)(struct platform_device *);
> > 		int (*suspend)(struct platform_device *, u32);
> > 		int (*resume)(struct platform_device *);
> > 		struct device_driver drv;
> > 	};
> > 
> > (Aside: I like the movement of the suspend/resume methods to the bus_type,
> > and I'd like to see the probe/remove methods also move there.  For the
> > vast majority of cases, the probe/remove methods in struct device_driver
> > end up pointing at the same functions for any particular bus.)
> 
> But what about those few devices that need special handling? Like
> flush write cache on IDE disk but not on cdrom?

ide-cd should have a flush write cache as well, for mtr, dvd-ram, cd-rw
with packet writing, etc.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
On Mon, Sep 01 2003, Pavel Machek wrote:
> Hi!
> 
> > I think we need to expand the platform device support to include the
> > notion of platform drivers.  For example:
> > 
> > 	struct platform_driver {
> > 		int (*probe)(struct platform_device *);
> > 		int (*remove)(struct platform_device *);
> > 		int (*suspend)(struct platform_device *, u32);
> > 		int (*resume)(struct platform_device *);
> > 		struct device_driver drv;
> > 	};
> > 
> > (Aside: I like the movement of the suspend/resume methods to the bus_type,
> > and I'd like to see the probe/remove methods also move there.  For the
> > vast majority of cases, the probe/remove methods in struct device_driver
> > end up pointing at the same functions for any particular bus.)
> 
> But what about those few devices that need special handling? Like
> flush write cache on IDE disk but not on cdrom?

ide-cd should have a flush write cache as well, for mtr, dvd-ram, cd-rw
with packet writing, etc.

-- 
Jens Axboe


  reply	other threads:[~2003-09-02 18:20 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-22 21:08 [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Pavel Machek
2003-08-22 21:25 ` Patrick Mochel
2003-08-22 21:53   ` Pavel Machek
2003-08-22 22:05     ` Patrick Mochel
2003-08-23  1:03       ` Nigel Cunningham
2003-08-23 16:22       ` Benjamin Herrenschmidt
2003-08-25 19:05         ` [PM] powering down special devices Patrick Mochel
2003-08-25 19:53           ` Benjamin Herrenschmidt
2003-08-25  9:52       ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Pavel Machek
2003-08-22 22:10   ` Pavel Machek
2003-08-22 22:13     ` Patrick Mochel
2003-08-22 22:17       ` Patrick Mochel
2003-08-22 22:36   ` Pavel Machek
2003-08-23 10:47   ` Russell King
2003-08-24 11:54     ` Russell King
2003-08-26 15:39       ` [PM] Config Options Patrick Mochel
2003-08-24 12:08     ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Russell King
2003-08-25 15:47     ` Patrick Mochel
2003-08-25 16:27       ` Russell King
2003-08-25 16:57         ` Matt Porter
2003-08-25 17:14           ` Russell King
2003-08-25 17:34             ` Matt Porter
2003-08-28 15:38         ` Platform Devices Patrick Mochel
2003-09-01 12:02         ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Pavel Machek
2003-09-02 17:41           ` Jens Axboe [this message]
2003-09-09 20:19             ` Benjamin Herrenschmidt
2003-09-09 20:24               ` Jens Axboe
2003-09-09 21:43               ` Patrick Mochel
2003-09-09 22:54                 ` Pavel Machek
2003-09-09 23:07                   ` Patrick Mochel
2003-09-09 23:07                     ` [PM] Passing suspend level down to drivers Pavel Machek
2003-09-09 23:23                       ` Patrick Mochel
2003-09-10  0:06                         ` Pavel Machek
2003-09-10  6:12                       ` Stephen Rothwell
2003-09-10 11:48                         ` Alan Cox
2003-09-09 23:15                     ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Alan Cox
2003-09-09 22:56               ` Pavel Machek
2003-08-25 17:16       ` Russell King
2003-08-22 22:04 ` Timothy Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030902174126.GB14209@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).