Re: [BUG] Ricoh Cardbus -> Can't get interrupts

From: David Hinds <dhinds@sonic.net>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Ricoh Cardbus -> Can't get interrupts
Date: Thu, 27 Nov 2003 10:56:12 -0800	[thread overview]
Message-ID: <20031127105612.B28106@sonic.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0311241906500.1986-100000@bigblue.dev.mdolabs.com>

On Mon, Nov 24, 2003 at 07:08:26PM -0800, Davide Libenzi wrote:
> 
> I didn't want to post this because I was ashamed of the fix, but w/out 
> this my orinoco cardbus gets an interrupt one every ten boots. This is 
> against 2.4.20 ...
> 
> - Davide

Your patch seems to do two things:

First, it automatically falls back on using a socket's PCI interrupt
if its ISA interrupts are not available.  That part seems ok.

But, it also falls back on sharing an interrupt if a driver requested
an exclusive interrupt and that was not available.  This part is not
ok.  The original code will share a PCI interrupt automatically, but
will not share an ISA interrupt except under certain circumstances
(for multifunction cards or when the driver specifically requests it).
Sharing ISA interrupts is unsafe and should never be done blindly.

-- Dave