Re: [BUG] Ricoh Cardbus -> Can't get interrupts

[Davide Libenzi <davidel@xmailserver.org>]

On Thu, 27 Nov 2003, David Hinds wrote:

> On Mon, Nov 24, 2003 at 07:08:26PM -0800, Davide Libenzi wrote:
> > 
> > I didn't want to post this because I was ashamed of the fix, but w/out 
> > this my orinoco cardbus gets an interrupt one every ten boots. This is 
> > against 2.4.20 ...
> > 
> > - Davide
> 
> Your patch seems to do two things:
> 
> First, it automatically falls back on using a socket's PCI interrupt
> if its ISA interrupts are not available.  That part seems ok.
> 
> But, it also falls back on sharing an interrupt if a driver requested
> an exclusive interrupt and that was not available.  This part is not
> ok.  The original code will share a PCI interrupt automatically, but
> will not share an ISA interrupt except under certain circumstances
> (for multifunction cards or when the driver specifically requests it).
> Sharing ISA interrupts is unsafe and should never be done blindly.

I told you it was bogus :) Seriously, I don't even know if the "bogus path"
is ever taken, I believe not. I did a quick fix at the beginning and I 
did not look at it anymore. I'll give it a shot ...



- Davide