From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: vatsa@in.ibm.com, linux-kernel@vger.kernel.org,
Dipankar Sarma <dipankar@in.ibm.com>,
Manfred Spraul <manfred@colorfullife.com>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] rcu: fix hotplug-cpu ->donelist leak
Date: Wed, 11 Jan 2006 08:28:09 -0800 [thread overview]
Message-ID: <20060111162809.GC21885@us.ibm.com> (raw)
In-Reply-To: <43C3C3B5.61D5641@tv-sign.ru>
On Tue, Jan 10, 2006 at 05:24:53PM +0300, Oleg Nesterov wrote:
> Pointed out by Srivatsa Vaddagiri <vatsa@in.ibm.com>.
>
> rcu_do_batch() stops after processing maxbatch callbacks
> on ->donelist leaving rcu_tasklet in TASKLET_STATE_SCHED
> state.
>
> If CPU_DEAD event happens remaining ->donelist entries are
> lost, rcu_offline_cpu() kills this tasklet.
>
> With this patch ->donelist migrates along with ->curlist
> and ->nxtlist to the current cpu.
>
> Compile tested.
This passed a ten-hour RCU torture test, with the torture test augmented
by Vatsa's CPU-hotplug RCU-torture-test patch.
Thanx, Paul
Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.15/kernel/rcupdate.c~4_HPFIX 2006-01-10 19:06:38.000000000 +0300
> +++ 2.6.15/kernel/rcupdate.c 2006-01-10 19:15:01.000000000 +0300
> @@ -343,8 +343,9 @@ static void __rcu_offline_cpu(struct rcu
> spin_unlock_bh(&rcp->lock);
> rcu_move_batch(this_rdp, rdp->curlist, rdp->curtail);
> rcu_move_batch(this_rdp, rdp->nxtlist, rdp->nxttail);
> -
> + rcu_move_batch(this_rdp, rdp->donelist, rdp->donetail);
> }
> +
> static void rcu_offline_cpu(int cpu)
> {
> struct rcu_data *this_rdp = &get_cpu_var(rcu_data);
>
next prev parent reply other threads:[~2006-01-11 16:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 19:19 [PATCH 2/5] rcu: don't check ->donelist in __rcu_pending() Oleg Nesterov
2006-01-08 22:00 ` Paul E. McKenney
2006-01-09 9:31 ` Srivatsa Vaddagiri
2006-01-09 14:51 ` Oleg Nesterov
2006-01-09 13:42 ` Srivatsa Vaddagiri
2006-01-09 15:33 ` Oleg Nesterov
2006-01-09 18:59 ` Paul E. McKenney
2006-01-09 20:31 ` Oleg Nesterov
2006-01-09 19:59 ` Paul E. McKenney
2006-01-10 9:58 ` Srivatsa Vaddagiri
2006-01-10 14:24 ` [PATCH] rcu: fix hotplug-cpu ->donelist leak Oleg Nesterov
2006-01-11 5:01 ` Paul E. McKenney
2006-01-11 16:28 ` Paul E. McKenney [this message]
2006-01-11 19:25 ` Oleg Nesterov
2006-01-11 18:21 ` Paul E. McKenney
2006-01-10 14:27 ` [PATCH 2/5] rcu: don't check ->donelist in __rcu_pending() Oleg Nesterov
2006-01-10 18:13 ` Dipankar Sarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111162809.GC21885@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).