From: Oleg Nesterov <oleg@tv-sign.ru>
To: linux-kernel@vger.kernel.org
Cc: Dipankar Sarma <dipankar@in.ibm.com>,
Manfred Spraul <manfred@colorfullife.com>,
Linus Torvalds <torvalds@osdl.org>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH 2/5] rcu: don't check ->donelist in __rcu_pending()
Date: Sun, 08 Jan 2006 22:19:24 +0300 [thread overview]
Message-ID: <43C165BC.F7C6DCF5@tv-sign.ru> (raw)
->donelist becomes != NULL only in rcu_process_callbacks().
rcu_process_callbacks() always calls rcu_do_batch() when
->donelist != NULL.
rcu_do_batch() schedules rcu_process_callbacks() again if
->donelist was not flushed entirely.
So ->donelist != NULL means that rcu_tasklet is either
TASKLET_STATE_SCHED or TASKLET_STATE_RUN, we don't need to
check it in __rcu_pending().
[ This patch was tested with rcutorture.ko, I don't understand
it's output, but it says "End of test: SUCCESS". So if this
patch incorrect blame Paul, not me! ]
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.15/kernel/rcupdate.c~2_DONE 2006-01-08 21:35:21.000000000 +0300
+++ 2.6.15/kernel/rcupdate.c 2006-01-08 21:55:45.000000000 +0300
@@ -454,10 +454,6 @@ static int __rcu_pending(struct rcu_ctrl
if (!rdp->curlist && rdp->nxtlist)
return 1;
- /* This cpu has finished callbacks to invoke */
- if (rdp->donelist)
- return 1;
-
/* The rcu core waits for a quiescent state from the cpu */
if (rdp->quiescbatch != rcp->cur || rdp->qs_pending)
return 1;
next reply other threads:[~2006-01-08 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 19:19 Oleg Nesterov [this message]
2006-01-08 22:00 ` [PATCH 2/5] rcu: don't check ->donelist in __rcu_pending() Paul E. McKenney
2006-01-09 9:31 ` Srivatsa Vaddagiri
2006-01-09 14:51 ` Oleg Nesterov
2006-01-09 13:42 ` Srivatsa Vaddagiri
2006-01-09 15:33 ` Oleg Nesterov
2006-01-09 18:59 ` Paul E. McKenney
2006-01-09 20:31 ` Oleg Nesterov
2006-01-09 19:59 ` Paul E. McKenney
2006-01-10 9:58 ` Srivatsa Vaddagiri
2006-01-10 14:24 ` [PATCH] rcu: fix hotplug-cpu ->donelist leak Oleg Nesterov
2006-01-11 5:01 ` Paul E. McKenney
2006-01-11 16:28 ` Paul E. McKenney
2006-01-11 19:25 ` Oleg Nesterov
2006-01-11 18:21 ` Paul E. McKenney
2006-01-10 14:27 ` [PATCH 2/5] rcu: don't check ->donelist in __rcu_pending() Oleg Nesterov
2006-01-10 18:13 ` Dipankar Sarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C165BC.F7C6DCF5@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=paulmck@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).