Re: RT Mutex patch and tester [PREEMPT_RT]

From: Ingo Molnar <mingo@elte.hu>
To: Esben Nielsen <simlo@phys.au.dk>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	david singleton <dsingleton@mvista.com>,
	Bill Huey <billh@gnuppy.monkey.org>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: RT Mutex patch and tester [PREEMPT_RT]
Date: Wed, 18 Jan 2006 11:38:39 +0100	[thread overview]
Message-ID: <20060118103839.GA7885@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0601181120100.1993-201000@lifa02.phys.au.dk>

* Esben Nielsen <simlo@phys.au.dk> wrote:

> Hi,
>  I have updated it:
> 
> 1) Now ALL_TASKS_PI is 0 again. Only RT tasks will be added to
> task->pi_waiters. Therefore we avoid taking the owner->pi_lock when the
> waiter isn't RT.
> 2) Merged into 2.6.15-rt6.
> 3) Updated the tester to test the hand over of BKL, which was mentioned
> as a potential issue by Bill Huey. Also added/adjusted the tests for the
> ALL_TASKS_PI==0 setup.
> (I really like unittesting: If someone points out an issue or finds a bug,
> make a test first demonstrating the problem. Then fixing the code is a lot
> easier - especially in this case where I run rt.c in userspace where I can
> easily use gdb.)

looks really nice to me. In particular i like the cleanup effect:

 5 files changed, 490 insertions(+), 744 deletions(-)

right now Thomas is merging hrtimer-latest to -rt, which temporarily 
blocks merging of intrusive patches - but i'll try to merge your patch 
after Thomas is done. (hopefully later today)

	Ingo