* x86_64, dwarf2: push pushes 8 bytes and popf pops 8
@ 2008-07-22 16:14 Alexander van Heukelum
2008-07-24 10:33 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Alexander van Heukelum @ 2008-07-22 16:14 UTC (permalink / raw)
To: LKML, Ingo Molnar; +Cc: Andi Kleen, heukelum
The CFI_ADJUST_CFA_OFFSET dwarf2 annotation of a push/popf
pair in ret_from_fork wrongly used a value of 4. It should
have been 8. Fix that.
Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index ae63e58..5f6cac6 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -269,9 +269,9 @@ ENTRY(native_usergs_sysret64)
ENTRY(ret_from_fork)
CFI_DEFAULT_STACK
push kernel_eflags(%rip)
- CFI_ADJUST_CFA_OFFSET 4
+ CFI_ADJUST_CFA_OFFSET 8
popf # reset kernel eflags
- CFI_ADJUST_CFA_OFFSET -4
+ CFI_ADJUST_CFA_OFFSET -8
call schedule_tail
GET_THREAD_INFO(%rcx)
testl $(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT),TI_flags(%rcx)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: x86_64, dwarf2: push pushes 8 bytes and popf pops 8
2008-07-22 16:14 x86_64, dwarf2: push pushes 8 bytes and popf pops 8 Alexander van Heukelum
@ 2008-07-24 10:33 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-07-24 10:33 UTC (permalink / raw)
To: Alexander van Heukelum
Cc: LKML, Andi Kleen, heukelum, the arch/x86 maintainers
* Alexander van Heukelum <heukelum@mailshack.com> wrote:
> The CFI_ADJUST_CFA_OFFSET dwarf2 annotation of a push/popf pair in
> ret_from_fork wrongly used a value of 4. It should have been 8. Fix
> that.
applied to tip/x86/debug - thanks Alexander.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-24 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-22 16:14 x86_64, dwarf2: push pushes 8 bytes and popf pops 8 Alexander van Heukelum
2008-07-24 10:33 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).