* [PATCH] regulator: Add rdev_crit() macro
@ 2011-06-09 15:06 Mark Brown
2011-06-09 18:15 ` Liam Girdwood
2011-06-09 18:37 ` Joe Perches
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2011-06-09 15:06 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-kernel, patches, Mark Brown
No actual users but provide the macro so there's less surprise when it's
not there.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 47bf85d..f5e4665 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -34,6 +34,8 @@
#include "dummy.h"
+#define rdev_crit(rdev, fmt, ...) \
+ pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
#define rdev_err(rdev, fmt, ...) \
pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
#define rdev_warn(rdev, fmt, ...) \
--
1.7.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: Add rdev_crit() macro
2011-06-09 15:06 [PATCH] regulator: Add rdev_crit() macro Mark Brown
@ 2011-06-09 18:15 ` Liam Girdwood
2011-06-09 18:37 ` Joe Perches
1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-06-09 18:15 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, patches
On 09/06/11 16:06, Mark Brown wrote:
> No actual users but provide the macro so there's less surprise when it's
> not there.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: Add rdev_crit() macro
2011-06-09 15:06 [PATCH] regulator: Add rdev_crit() macro Mark Brown
2011-06-09 18:15 ` Liam Girdwood
@ 2011-06-09 18:37 ` Joe Perches
2011-06-09 19:09 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2011-06-09 18:37 UTC (permalink / raw)
To: Mark Brown; +Cc: Liam Girdwood, linux-kernel, patches
On Thu, 2011-06-09 at 16:06 +0100, Mark Brown wrote:
> No actual users but provide the macro so there's less surprise when it's
> not there.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 47bf85d..f5e4665 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -34,6 +34,8 @@
>
> #include "dummy.h"
>
> +#define rdev_crit(rdev, fmt, ...) \
> + pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> #define rdev_err(rdev, fmt, ...) \
> pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> #define rdev_warn(rdev, fmt, ...) \
If that's really necessary, shouldn't rdev_emerg, rdev_alert
and rdev_notice be added as well?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: Add rdev_crit() macro
2011-06-09 18:37 ` Joe Perches
@ 2011-06-09 19:09 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-06-09 19:09 UTC (permalink / raw)
To: Joe Perches; +Cc: Liam Girdwood, linux-kernel, patches
On Thu, Jun 09, 2011 at 11:37:15AM -0700, Joe Perches wrote:
> > +#define rdev_crit(rdev, fmt, ...) \
> > + pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> If that's really necessary, shouldn't rdev_emerg, rdev_alert
> and rdev_notice be added as well?
Yes, but I don't habitually use those when adding random trace during
debug so don't care myself.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-09 19:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-09 15:06 [PATCH] regulator: Add rdev_crit() macro Mark Brown
2011-06-09 18:15 ` Liam Girdwood
2011-06-09 18:37 ` Joe Perches
2011-06-09 19:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).