From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>,
reiserfs-devel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the vfs tree
Date: Thu, 5 Jan 2012 12:34:48 +0100 [thread overview]
Message-ID: <20120105113448.GA14947@quack.suse.cz> (raw)
In-Reply-To: <20120105081418.GI23916@ZenIV.linux.org.uk>
On Thu 05-01-12 08:14:18, Al Viro wrote:
> On Thu, Jan 05, 2012 at 08:06:57AM +0000, Al Viro wrote:
> > On Thu, Jan 05, 2012 at 05:35:21PM +1100, Stephen Rothwell wrote:
> > > Hi Al,
> > >
> > > After merging the vfs tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > fs/reiserfs/super.c:701:2: warning: initialization from incompatible pointer type [enabled by default]
> > > fs/reiserfs/super.c:701:2: warning: (near initialization for 'reiserfs_sops.show_options') [enabled by default]
> > >
> > > Caused by commit 2ddeb2a58b11 ("vfs: switch ->show_options() to struct
> > > dentry *") interacting with commit f1823b7b87d1 ("reiserfs: Properly
> > > display mount options in /proc/mounts") from the ext3. This needs some
> > > merge fix ... (and will probably currently cause crashes :-()
> >
> > Grrr... Same as changes in the first commit, done to the function introduced
> > by the second (i.e. replace mnt->mnt_sb with dentry->d_sb). Incidentally,
> > what are reiserfs patches doing in ext3 tree, of all places?
>
> FWIW, an updated variant of Jan's patch would be this (on top of
> vfs.git#for-next; I can pull his commit there in such form):
Thanks. I'm removing the old version of the patch from my tree so please
carry the new version in your tree. I was just carrying the patch because
of lack of reiserfs maintainer and because I originally wrote the patch to
accommodate needs of quota tools...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-01-05 11:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 6:35 linux-next: build warning after merge of the vfs tree Stephen Rothwell
2012-01-05 8:06 ` Al Viro
2012-01-05 8:14 ` Al Viro
2012-01-05 11:34 ` Jan Kara [this message]
2012-01-05 8:14 ` Stephen Rothwell
2012-01-05 8:19 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2021-04-12 11:47 Stephen Rothwell
2021-04-12 13:07 ` Miklos Szeredi
2021-04-15 21:19 ` Al Viro
2021-01-06 23:15 Stephen Rothwell
2021-01-07 0:37 ` Gao Xiang
2021-01-07 0:40 ` Al Viro
2020-09-24 1:40 Stephen Rothwell
2020-09-24 2:00 ` Al Viro
2020-06-16 0:21 Stephen Rothwell
2020-03-09 22:59 Stephen Rothwell
2020-03-09 23:17 ` Pali Rohár
2020-03-09 23:36 ` Namjae Jeon
2020-03-10 10:32 ` 'Greg Kroah-Hartman'
2019-02-03 22:33 Stephen Rothwell
2019-03-18 0:00 ` Stephen Rothwell
2019-03-25 23:05 ` Stephen Rothwell
2018-09-06 0:02 Stephen Rothwell
2018-09-07 8:57 ` David Howells
2018-06-19 1:53 Stephen Rothwell
2018-06-19 1:29 Stephen Rothwell
2018-05-17 0:39 Stephen Rothwell
2018-05-17 6:41 ` Christoph Hellwig
2018-05-14 0:56 Stephen Rothwell
2017-09-07 23:25 Stephen Rothwell
2017-09-08 5:53 ` Dmitry V. Levin
2017-09-14 1:51 ` Stephen Rothwell
2017-07-03 0:53 Stephen Rothwell
2017-07-09 23:34 ` Stephen Rothwell
2015-04-13 4:00 Stephen Rothwell
2012-10-12 5:06 Stephen Rothwell
2012-09-25 1:52 Stephen Rothwell
2011-07-18 5:04 Stephen Rothwell
2011-07-18 5:17 ` Al Viro
2011-07-18 5:20 ` Al Viro
2010-07-05 0:01 Stephen Rothwell
2010-07-05 8:10 ` Al Viro
2010-07-05 10:44 ` Stephen Rothwell
2010-07-05 12:15 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105113448.GA14947@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).