linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the vfs tree
Date: Thu, 7 Jan 2021 00:40:06 +0000	[thread overview]
Message-ID: <20210107004006.GF3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20210107101544.68bdd395@canb.auug.org.au>

On Thu, Jan 07, 2021 at 10:15:44AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> In file included from fs/erofs/xattr.h:10,
>                  from fs/erofs/namei.c:7:
> fs/erofs/namei.c: In function 'erofs_lookup':
> fs/erofs/internal.h:23:21: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'struct dentry *' [-Wformat=]
>    23 | #define pr_fmt(fmt) "erofs: " fmt
>       |                     ^~~~~~~~~
> include/linux/dynamic_debug.h:129:15: note: in expansion of macro 'pr_fmt'
>   129 |   func(&id, ##__VA_ARGS__);  \
>       |               ^~~~~~~~~~~
> include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
>   147 |  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
>       |  ^~~~~~~~~~~~~~~~~~~
> include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
>   157 |  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
>       |  ^~~~~~~~~~~~~~~~~~
> include/linux/printk.h:424:2: note: in expansion of macro 'dynamic_pr_debug'
>   424 |  dynamic_pr_debug(fmt, ##__VA_ARGS__)
>       |  ^~~~~~~~~~~~~~~~
> fs/erofs/internal.h:34:33: note: in expansion of macro 'pr_debug'
>    34 | #define erofs_dbg(x, ...)       pr_debug(x "\n", ##__VA_ARGS__)
>       |                                 ^~~~~~~~
> fs/erofs/namei.c:237:3: note: in expansion of macro 'erofs_dbg'
>   237 |   erofs_dbg("%pd, %s (nid %llu) found, d_type %u", __func__,
>       |   ^~~~~~~~~
> 
> Introduced by commit
> 
>   879d4376533c ("erofs: use %pd instead of messing with ->d_name")

Gyah...  "%s, %pd", not "%pd, %s".  Sorry, fixed and pushed.

  parent reply	other threads:[~2021-01-07  0:41 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 23:15 linux-next: build warning after merge of the vfs tree Stephen Rothwell
2021-01-07  0:37 ` Gao Xiang
2021-01-07  0:40 ` Al Viro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-12 11:47 Stephen Rothwell
2021-04-12 13:07 ` Miklos Szeredi
2021-04-15 21:19   ` Al Viro
2020-09-24  1:40 Stephen Rothwell
2020-09-24  2:00 ` Al Viro
2020-06-16  0:21 Stephen Rothwell
2020-03-09 22:59 Stephen Rothwell
2020-03-09 23:17 ` Pali Rohár
2020-03-09 23:36   ` Namjae Jeon
2020-03-10 10:32     ` 'Greg Kroah-Hartman'
2019-02-03 22:33 Stephen Rothwell
2019-03-18  0:00 ` Stephen Rothwell
2019-03-25 23:05   ` Stephen Rothwell
2018-09-06  0:02 Stephen Rothwell
2018-09-07  8:57 ` David Howells
2018-06-19  1:53 Stephen Rothwell
2018-06-19  1:29 Stephen Rothwell
2018-05-17  0:39 Stephen Rothwell
2018-05-17  6:41 ` Christoph Hellwig
2018-05-14  0:56 Stephen Rothwell
2017-09-07 23:25 Stephen Rothwell
2017-09-08  5:53 ` Dmitry V. Levin
2017-09-14  1:51 ` Stephen Rothwell
2017-07-03  0:53 Stephen Rothwell
2017-07-09 23:34 ` Stephen Rothwell
2015-04-13  4:00 Stephen Rothwell
2012-10-12  5:06 Stephen Rothwell
2012-09-25  1:52 Stephen Rothwell
2012-01-05  6:35 Stephen Rothwell
2012-01-05  8:06 ` Al Viro
2012-01-05  8:14   ` Al Viro
2012-01-05 11:34     ` Jan Kara
2012-01-05  8:14   ` Stephen Rothwell
2012-01-05  8:19     ` Al Viro
2011-07-18  5:04 Stephen Rothwell
2011-07-18  5:17 ` Al Viro
2011-07-18  5:20   ` Al Viro
2010-07-05  0:01 Stephen Rothwell
2010-07-05  8:10 ` Al Viro
2010-07-05 10:44   ` Stephen Rothwell
2010-07-05 12:15   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107004006.GF3579531@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).