* [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size
@ 2012-01-26 21:01 Stefan Gula
2012-01-26 21:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Gula @ 2012-01-26 21:01 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel
From: Stefan Gula <steweg@gmail.com>
Setting link parameters on a netdevice changes the value
of if_nlmsg_size(), therefore it is necessary to recalculate
min_ifinfo_dump_size.
Signed-off-by: Stefan Gula <steweg@gmail.com>
---
V2-changelog: adjusted commit message
--- linux-3.2.1-orig/net/core/rtnetlink.c 2012-01-12 20:42:45.000000000 +0100
+++ linux/net/core/rtnetlink.c 2012-01-24 14:26:58.083219352 +0100
@@ -1506,6 +1506,9 @@ errout:
if (send_addr_notify)
call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
+ min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
+ min_ifinfo_dump_size);
+
return err;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size
2012-01-26 21:01 [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size Stefan Gula
@ 2012-01-26 21:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-01-26 21:37 UTC (permalink / raw)
To: steweg; +Cc: netdev, linux-kernel
From: Stefan Gula <steweg@ynet.sk>
Date: Thu, 26 Jan 2012 22:01:06 +0100 (CET)
> From: Stefan Gula <steweg@gmail.com>
>
> Setting link parameters on a netdevice changes the value
> of if_nlmsg_size(), therefore it is necessary to recalculate
> min_ifinfo_dump_size.
>
> Signed-off-by: Stefan Gula <steweg@gmail.com>
Applied, but:
> + min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
> + min_ifinfo_dump_size);
> +
The second line is not properly indented, the first non-space
character should line up with the first column after the
openning parenthesis on the previous line.
I fixed this up, but really this was a lot of tooth pulling to
get you to post this patch correctly. You cannot consume this
much maintainer and reviewer resources in the future.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-26 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-26 21:01 [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size Stefan Gula
2012-01-26 21:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).