* [PATCH] kcore: make get_sparsemem_vmemmap_info static
@ 2012-01-26 22:37 Djalal Harouni
2012-01-28 15:18 ` Cong Wang
0 siblings, 1 reply; 2+ messages in thread
From: Djalal Harouni @ 2012-01-26 22:37 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel
get_sparsemem_vmemmap_info() is only used inside fs/proc/kcore.c
Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
---
fs/proc/kcore.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index d245cb2..699e92b 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -157,7 +157,8 @@ static int kcore_update_ram(void)
#ifdef CONFIG_SPARSEMEM_VMEMMAP
/* calculate vmemmap's address from given system ram pfn and register it */
-int get_sparsemem_vmemmap_info(struct kcore_list *ent, struct list_head *head)
+static int
+get_sparsemem_vmemmap_info(struct kcore_list *ent, struct list_head *head)
{
unsigned long pfn = __pa(ent->addr) >> PAGE_SHIFT;
unsigned long nr_pages = ent->size >> PAGE_SHIFT;
@@ -189,7 +190,8 @@ int get_sparsemem_vmemmap_info(struct kcore_list *ent, struct list_head *head)
}
#else
-int get_sparsemem_vmemmap_info(struct kcore_list *ent, struct list_head *head)
+static int
+get_sparsemem_vmemmap_info(struct kcore_list *ent, struct list_head *head)
{
return 1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kcore: make get_sparsemem_vmemmap_info static
2012-01-26 22:37 [PATCH] kcore: make get_sparsemem_vmemmap_info static Djalal Harouni
@ 2012-01-28 15:18 ` Cong Wang
0 siblings, 0 replies; 2+ messages in thread
From: Cong Wang @ 2012-01-28 15:18 UTC (permalink / raw)
To: Djalal Harouni; +Cc: Linus Torvalds, Andrew Morton, linux-kernel
On 01/27/2012 06:37 AM, Djalal Harouni wrote:
> get_sparsemem_vmemmap_info() is only used inside fs/proc/kcore.c
>
> Signed-off-by: Djalal Harouni<tixxdz@opendz.org>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-28 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-26 22:37 [PATCH] kcore: make get_sparsemem_vmemmap_info static Djalal Harouni
2012-01-28 15:18 ` Cong Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).