* [PATCH 6/9] arch/arm/mach-omap2/devices.c: introduce missing kfree
@ 2011-12-23 17:39 Julia Lawall
2012-01-26 23:59 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2011-12-23 17:39 UTC (permalink / raw)
To: Tony Lindgren
Cc: kernel-janitors, Russell King, linux-omap, linux-arm-kernel,
linux-kernel
pdata needs to be freed before leaving the function in an error case.
A simplified version of the semantic match that finds the problem is as
follows: (http://coccinelle.lip6.fr)
// <smpl>
@r exists@
local idexpression x;
statement S;
identifier f1;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
x->f1
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/arm/mach-omap2/devices.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 46dfd1a..3334a47 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -393,6 +393,7 @@ static int omap_mcspi_init(struct omap_hwmod *oh, void *unused)
break;
default:
pr_err("Invalid McSPI Revision value\n");
+ kfree(pdata);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/9] arch/arm/mach-omap2/devices.c: introduce missing kfree
2011-12-23 17:39 [PATCH 6/9] arch/arm/mach-omap2/devices.c: introduce missing kfree Julia Lawall
@ 2012-01-26 23:59 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-01-26 23:59 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Russell King, linux-omap, linux-arm-kernel,
linux-kernel
* Julia Lawall <julia@diku.dk> [111223 09:07]:
> pdata needs to be freed before leaving the function in an error case.
Thanks applying into fixes.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-26 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-23 17:39 [PATCH 6/9] arch/arm/mach-omap2/devices.c: introduce missing kfree Julia Lawall
2012-01-26 23:59 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).