* [patch 2/2] sysctl: fix memset parameters in setup_sysctl_set()
@ 2012-01-30 13:40 Dan Carpenter
2012-01-31 5:20 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-01-30 13:40 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Al Viro, Andrew Morton, Lucas De Marchi, linux-kernel, kernel-janitors
The current code is a nop.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 1b1f5b8..27e265b 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -1547,7 +1547,7 @@ void setup_sysctl_set(struct ctl_table_set *set,
struct ctl_table_root *root,
int (*is_seen)(struct ctl_table_set *))
{
- memset(set, sizeof(*set), 0);
+ memset(set, 0, sizeof(*set));
set->is_seen = is_seen;
init_header(&set->dir.header, root, set, NULL, root_table);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/2] sysctl: fix memset parameters in setup_sysctl_set()
2012-01-30 13:40 [patch 2/2] sysctl: fix memset parameters in setup_sysctl_set() Dan Carpenter
@ 2012-01-31 5:20 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2012-01-31 5:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Al Viro, Andrew Morton, Lucas De Marchi, linux-kernel, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The current code is a nop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-31 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-30 13:40 [patch 2/2] sysctl: fix memset parameters in setup_sysctl_set() Dan Carpenter
2012-01-31 5:20 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).