* [PATCH] MAX_PAUSE to be at least 4
@ 2013-01-21 3:07 paul.szabo
2013-01-23 0:01 ` Jan Kara
2013-01-23 0:04 ` Andrew Morton
0 siblings, 2 replies; 3+ messages in thread
From: paul.szabo @ 2013-01-21 3:07 UTC (permalink / raw)
To: linux-mm; +Cc: 695182, linux-kernel
Ensure MAX_PAUSE is 4 or larger, so limits in
return clamp_val(t, 4, MAX_PAUSE);
(the only use of it) are not back-to-front.
(This patch does not solve the PAE OOM issue.)
Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
School of Mathematics and Statistics University of Sydney Australia
Reported-by: Paul Szabo <psz@maths.usyd.edu.au>
Reference: http://bugs.debian.org/695182
Signed-off-by: Paul Szabo <psz@maths.usyd.edu.au>
--- mm/page-writeback.c.old 2012-12-06 22:20:40.000000000 +1100
+++ mm/page-writeback.c 2013-01-21 13:57:05.000000000 +1100
@@ -39,7 +39,7 @@
/*
* Sleep at most 200ms at a time in balance_dirty_pages().
*/
-#define MAX_PAUSE max(HZ/5, 1)
+#define MAX_PAUSE max(HZ/5, 4)
/*
* Estimate write bandwidth at 200ms intervals.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MAX_PAUSE to be at least 4
2013-01-21 3:07 [PATCH] MAX_PAUSE to be at least 4 paul.szabo
@ 2013-01-23 0:01 ` Jan Kara
2013-01-23 0:04 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2013-01-23 0:01 UTC (permalink / raw)
To: paul.szabo; +Cc: linux-mm, 695182, linux-kernel
On Mon 21-01-13 14:07:34, paul.szabo@sydney.edu.au wrote:
> Ensure MAX_PAUSE is 4 or larger, so limits in
> return clamp_val(t, 4, MAX_PAUSE);
> (the only use of it) are not back-to-front.
>
> (This patch does not solve the PAE OOM issue.)
>
> Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
> School of Mathematics and Statistics University of Sydney Australia
I guess this isn't needed in patch changelog?
Also clamp_val(t, 4, MAX_PAUSE) doesn't seem to exist anymore?
Honza
> Reported-by: Paul Szabo <psz@maths.usyd.edu.au>
> Reference: http://bugs.debian.org/695182
> Signed-off-by: Paul Szabo <psz@maths.usyd.edu.au>
>
> --- mm/page-writeback.c.old 2012-12-06 22:20:40.000000000 +1100
> +++ mm/page-writeback.c 2013-01-21 13:57:05.000000000 +1100
> @@ -39,7 +39,7 @@
> /*
> * Sleep at most 200ms at a time in balance_dirty_pages().
> */
> -#define MAX_PAUSE max(HZ/5, 1)
> +#define MAX_PAUSE max(HZ/5, 4)
>
> /*
> * Estimate write bandwidth at 200ms intervals.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MAX_PAUSE to be at least 4
2013-01-21 3:07 [PATCH] MAX_PAUSE to be at least 4 paul.szabo
2013-01-23 0:01 ` Jan Kara
@ 2013-01-23 0:04 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2013-01-23 0:04 UTC (permalink / raw)
To: paul.szabo; +Cc: linux-mm, 695182, linux-kernel, Wu Fengguang
On Mon, 21 Jan 2013 14:07:34 +1100
paul.szabo@sydney.edu.au wrote:
> Ensure MAX_PAUSE is 4 or larger, so limits in
> return clamp_val(t, 4, MAX_PAUSE);
> (the only use of it) are not back-to-front.
MAX_PAUSE is not used in this fashion in current kernels.
> (This patch does not solve the PAE OOM issue.)
>
> Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
> School of Mathematics and Statistics University of Sydney Australia
>
> Reported-by: Paul Szabo <psz@maths.usyd.edu.au>
> Reference: http://bugs.debian.org/695182
> Signed-off-by: Paul Szabo <psz@maths.usyd.edu.au>
>
> --- mm/page-writeback.c.old 2012-12-06 22:20:40.000000000 +1100
> +++ mm/page-writeback.c 2013-01-21 13:57:05.000000000 +1100
> @@ -39,7 +39,7 @@
> /*
> * Sleep at most 200ms at a time in balance_dirty_pages().
> */
> -#define MAX_PAUSE max(HZ/5, 1)
> +#define MAX_PAUSE max(HZ/5, 4)
>
> /*
> * Estimate write bandwidth at 200ms intervals.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-23 0:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-21 3:07 [PATCH] MAX_PAUSE to be at least 4 paul.szabo
2013-01-23 0:01 ` Jan Kara
2013-01-23 0:04 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).